From: Vlad Buslov <vladbu@mellanox.com>
To: wenxu@ucloud.cn
Cc: netdev@vger.kernel.org, pablo@netfilter.org, vladbu@mellanox.com
Subject: Re: [PATCH net v2 1/4] flow_offload: fix incorrect cleanup for indirect flow_blocks
Date: Mon, 15 Jun 2020 14:05:49 +0300 [thread overview]
Message-ID: <vbfr1ug612q.fsf@mellanox.com> (raw)
In-Reply-To: <1592040362-25389-1-git-send-email-wenxu@ucloud.cn>
On Sat 13 Jun 2020 at 12:25, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
>
> If the representor is removed, then identify the indirect
> flow_blocks that need to be removed by the release callback.
>
> Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
> Signed-off-by: wenxu <wenxu@ucloud.cn>
> ---
Hi,
It is hard for me to review the code itself (because it lacks cover
letter, doesn't describe in any detail what problem it tries to fix or
provide steps to reproduce it, and lacks a changelog), but this version
of the series passes our test suite.
Regards,
Vlad
prev parent reply other threads:[~2020-06-15 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 9:25 [PATCH net v2 1/4] flow_offload: fix incorrect cleanup for indirect flow_blocks wenxu
2020-06-13 9:26 ` [PATCH net v2 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb wenxu
2020-06-13 9:26 ` [PATCH net v2 3/4] net/sched: cls_api: fix nooffloaddevcnt warning dmesg log wenxu
2020-06-13 9:26 ` [PATCH net v2 4/4] flow_offload: fix the list_del corruption in the driver list wenxu
2020-06-15 11:05 ` Vlad Buslov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vbfr1ug612q.fsf@mellanox.com \
--to=vladbu@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).