From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Machata Subject: Re: [PATCH net v2 3/4] vxlan: changelink: Fix handling of default remotes Date: Tue, 18 Dec 2018 11:20:35 +0000 Message-ID: References: <0875afa5bd3c6df61c02595d9ee7a1651e9b54c5.1545068986.git.petrm@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , Ido Schimmel To: Roopa Prabhu Return-path: Received: from mail-eopbgr150071.outbound.protection.outlook.com ([40.107.15.71]:11776 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726379AbeLRLUj (ORCPT ); Tue, 18 Dec 2018 06:20:39 -0500 In-Reply-To: (Roopa Prabhu's message of "Mon, 17 Dec 2018 17:30:33 -0800") Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Roopa Prabhu writes: > On Mon, Dec 17, 2018 at 3:44 PM Petr Machata wrote: >> >> Roopa Prabhu writes: >> >> Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify ord= ering during netdev create") >> >> Signed-off-by: Petr Machata >> >> --- >> > >> > Acked-by: Roopa Prabhu >> > >> > This fix looks fine. But it almost seems like the changelink Fixes tag >> > is more appropriate here unless you are >> > sure that it worked correctly after the changelink. >> >> I don't follow. What do you mean? > > I meant the notify patch in the Fixes tag had no intentions to change > this. Also the vxlan changelink support > did not consider this as a test case. So i was wondering if this > problem existed before the commit in the Fixes tag. That patch changed vxlan_fdb_update() to vxlan_fdb_create() in two instances: on changelink, and on create. In changelink, always calling create may lead to a split of the default FDB entry. The fix is basically a revert of that part of the patch. > regardless, ack on the fix. thanks.