From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr10042.outbound.protection.outlook.com ([40.107.1.42]:52800
        "EHLO EUR02-HE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752181AbeBZQcN (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 26 Feb 2018 11:32:13 -0500
From: Petr Machata <petrm@mellanox.com>
To: Ido Schimmel <idosch@mellanox.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        davem@davemloft.net, shuah@kernel.org, jiri@mellanox.com,
        dsahern@gmail.com, roopa@cumulusnetworks.com,
        nikolay@cumulusnetworks.com, f.fainelli@gmail.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning
References: <20180226085948.19368-1-idosch@mellanox.com>
        <20180226085948.19368-3-idosch@mellanox.com>
Date: Mon, 26 Feb 2018 18:31:49 +0200
In-Reply-To: <20180226085948.19368-3-idosch@mellanox.com> (Ido Schimmel's
        message of "Mon, 26 Feb 2018 10:59:36 +0200")
Message-ID: <wih4lm3pv9m.fsf@dev-r-vrt-156.mtr.labs.mlnx>
MIME-Version: 1.0
Content-Type: text/plain
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Ido Schimmel <idosch@mellanox.com> writes:

> +learning_test()
> +{
> +	local mac=de:ad:be:ef:13:37
> +	local ageing_time
> +	local br_port1=$2	# Connected to `host1_if`.
> +	local host1_if=$3
> +	local host2_if=$4
> +	local bridge=$1

I don't think applying RXT in Bash is appropriate. The ordering of the
local variables should instead follow the order of function arguments,
because that information isn't communicated by the function prototype
itself, unlike C.

Thanks,
Petr