From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr20060.outbound.protection.outlook.com ([40.107.2.60]:48976 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752892AbeBULV4 (ORCPT ); Wed, 21 Feb 2018 06:21:56 -0500 From: Petr Machata To: Serhey Popovych Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2-next v2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag References: <9c10d7d8-467a-eeef-87a4-5a8c84891d64@gmail.com> Date: Wed, 21 Feb 2018 13:21:34 +0200 In-Reply-To: <9c10d7d8-467a-eeef-87a4-5a8c84891d64@gmail.com> (Serhey Popovych's message of "Wed, 21 Feb 2018 08:45:20 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org List-ID: Serhey Popovych writes: > Petr Machata wrote: >> For IP-in-IP tunnels, one can specify the [no]allow-localremote command >> when configuring a device. Under the hood, this flips the >> IP6_TNL_F_ALLOW_LOCAL_REMOTE flag on the netdevice. However, ip6gretap >> and ip6erspan devices, where the flag is also relevant, are not IP-in-IP >> tunnels, and thus there's no way to configure the flag on these >> netdevices. Therefore introduce the command to link_gre6 as well. >> >> The original support was introduced in commit >> 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag") > > This would produce following checkpatch.pl error: > > ---------------------------------------------------------------------------------- > Commit b7a2f4a74cd0 ("ip: link_gre6.c: Support > IP6_TNL_F_ALLOW_LOCAL_REMOTE flag") > ---------------------------------------------------------------------------------- > WARNING: Possible unwrapped commit description (prefer a maximum 75 > chars per line) > #14: > 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support > IP6_TNL_F_ALLOW_LOCAL_REMOTE flag") > > ERROR: Please use git commit description style 'commit <12+ chars of > sha1> ("")' - ie: 'commit 21440d19d957 ("ip: > link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOT' > #14: > 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support > IP6_TNL_F_ALLOW_LOCAL_REMOTE flag") > > You probably should address it. In general change looks good to me. v3 sent. The "unwrapped commit description" warning stays on the commit reference line, but I don't see a way to shorten it without triggering the above error again. Thanks, Petr