Re: [PATCH net-next] selftests: net: Test headroom handling of ip6_gre devices

[Petr Machata <petrm@mellanox.com>]

William Tu <u9012063@gmail.com> writes:

>> +cleanup()
>> +{
>> +       ip link del dev swp1
>> +       ip link del dev swp3
>> +       ip link del dev vh3
> I think we also need to do:
> ip link del dev gt6

gt6 is removed in test_headroom, but for early-break sort of scenarios I
guess we do want to have it in cleanup() as well. With 2>/dev/null,
because most of the time it will have been cleaned up already. I'll send
a v2 like that.

>> +test_headroom()
>> +{
>> +       ip link add name gt6 "$@"
>> +       ip link set dev gt6 up
>> +
>> +       sleep 1
>> +
>> +       tc filter add dev swp1 ingress pref 1000 matchall skip_hw \
>> +               action mirred egress mirror dev gt6
>> +       ping -I h1 192.0.2.2 -c 1 -w 2 &> /dev/null
>
> I increase ping count from 1 to 1000
> and after a while the program hangs when I try to ctrl+c
> + cleanup
> + ip link del dev swp1
> dmesg shows:
> ....
> [ 1256.002453] unregister_netdevice: waiting for swp1 to become free.
> Usage count = 9
> [ 1266.082571] unregister_netdevice: waiting for swp1 to become free.
> Usage count = 9
> [ 1276.163011] unregister_netdevice: waiting for swp1 to become free.
> Usage count = 9

Interesting. Looks like another bug, the headroom issue would panic
after the first packet (and only after the first packet--increasing ping
count doesn't make it more likely to reproduce, rerunning the whole
script does).

Thanks,
Petr