From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ve1eur01on0086.outbound.protection.outlook.com ([104.47.1.86]:17996 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752157AbeB1OgF (ORCPT ); Wed, 28 Feb 2018 09:36:05 -0500 From: Petr Machata To: David Ahern Cc: Jiri Pirko , netdev@vger.kernel.org, idosch@mellanox.com, davem@davemloft.net, mlxsw@mellanox.com, xeb@mail.ru Subject: Re: [patch net-next 15/15] mlxsw: spectrum_span: Support mirror to ip6gretap In-Reply-To: (David Ahern's message of "Tue, 27 Feb 2018 13:17:17 -0700") References: <20180227135349.11637-1-jiri@resnulli.us> <20180227135349.11637-16-jiri@resnulli.us> Date: Wed, 28 Feb 2018 16:35:45 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org List-ID: David Ahern writes: > On 2/27/18 6:53 AM, Jiri Pirko wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> index 830c3e28505e..93d97b4676eb 100644 >> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> @@ -80,6 +80,8 @@ config MLXSW_SPECTRUM >> select MLXFW >> depends on NET_IPGRE >> depends on !(MLXSW_CORE=y && NET_IPGRE=m) >> + depends on IPV6_GRE >> + depends on !(MLXSW_CORE=y && IPV6_GRE=m) >> default m >> ---help--- >> This driver supports Mellanox Technologies Spectrum Ethernet > > Since mlxsw now has a hard dependency on IPv6 the 'if > IS_ENABLED(CONFIG_IPV6)' checks can be removed from the spectrum code. I'll add a default implementation of is_gretap_dev and is_ip6gretap_dev for cases where the corresponding code is not selected so that the Spectrum driver doesn't depend on all these modules. Thanks, Petr