From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Machata <petrm@mellanox.com>
Subject: Re: [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()
Date: Mon, 28 May 2018 16:39:00 +0300
Message-ID: <wihk1rngarv.fsf@dev-r-vrt-156.mtr.labs.mlnx>
References: <cover.1527503302.git.petrm@mellanox.com>
        <40d11322cdf295d5f5b03d7acaf997486e68ed2f.1527503302.git.petrm@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: <devel@driverdev.osuosl.org>, <bridge@lists.linux-foundation.org>,
        <jiri@mellanox.com>, <idosch@mellanox.com>, <davem@davemloft.net>,
        <razvan.stefanescu@nxp.com>, <gregkh@linuxfoundation.org>,
        <stephen@networkplumber.org>, <andrew@lunn.ch>,
        <vivien.didelot@savoirfairelinux.com>, <f.fainelli@gmail.com>,
        <nikolay@cumulusnetworks.com>
To: <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr30070.outbound.protection.outlook.com ([40.107.3.70]:29234
        "EHLO EUR03-AM5-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1033558AbeE1NjY (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 28 May 2018 09:39:24 -0400
In-Reply-To: <40d11322cdf295d5f5b03d7acaf997486e68ed2f.1527503302.git.petrm@mellanox.com>
        (Petr Machata's message of "Mon, 28 May 2018 12:49:55 +0200")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Petr Machata <petrm@mellanox.com> writes:

> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 11520ed..33bd914 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1178,6 +1178,9 @@ static inline void br_switchdev_frame_unmark(struct sk_buff *skb)
>  }
>  #endif /* CONFIG_NET_SWITCHDEV */
>  
> +int br_switchdev_port_vlan_add(struct net_device *dev, u16 vid, u16 flags);
> +int br_switchdev_port_vlan_del(struct net_device *dev, u16 vid);
> +

Nope, this actually does need to be in the ifdef block. The whole
br_switchdev.c is built conditionally.

I'll send v3.

Petr