From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Machata <petrm@mellanox.com>
Subject: Re: [PATCH net-next 01/18] net: skb_scrub_packet(): Scrub
 offload_fwd_mark
Date: Mon, 19 Nov 2018 22:41:10 +0000
Message-ID: <wihmuq4itc9.fsf@dev-r-vrt-156.mtr.labs.mlnx>
References: <20181119161006.5405-1-idosch@mellanox.com>
        <20181119161006.5405-2-idosch@mellanox.com>
        <20181119.110745.12820215456503449.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: Ido Schimmel <idosch@mellanox.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "shuah@kernel.org" <shuah@kernel.org>,
        Jiri Pirko <jiri@mellanox.com>,
        "roopa@cumulusnetworks.com" <roopa@cumulusnetworks.com>,
        mlxsw <mlxsw@mellanox.com>
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr140080.outbound.protection.outlook.com ([40.107.14.80]:53892
        "EHLO EUR01-VE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1731047AbeKTJHG (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 20 Nov 2018 04:07:06 -0500
In-Reply-To: <20181119.110745.12820215456503449.davem@davemloft.net> (David
        Miller's message of "Mon, 19 Nov 2018 11:07:45 -0800")
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

David Miller <davem@davemloft.net> writes:

> From: Ido Schimmel <idosch@mellanox.com>
> Date: Mon, 19 Nov 2018 16:11:07 +0000
>
>> From: Petr Machata <petrm@mellanox.com>
>>=20
>> When a packet is trapped and the corresponding SKB marked as
>> already-forwarded, it retains this marking even after it is forwarded
>> across veth links into another bridge. There, since it ingresses the
>> bridge over veth, which doesn't have offload_fwd_mark, it triggers a
>> warning in nbp_switchdev_frame_mark().
>>=20
>> Then nbp_switchdev_allowed_egress() decides not to allow egress from
>> this bridge through another veth, because the SKB is already marked, and
>> the mark (of 0) of course matches. Thus the packet is incorrectly
>> blocked.
>>=20
>> Solve by resetting offload_fwd_mark() in skb_scrub_packet(). That
>> function is called from tunnels and also from veth, and thus catches the
>> cases where traffic is forwarded between bridges and transformed in a
>> way that invalidates the marking.
>>=20
>> Signed-off-by: Petr Machata <petrm@mellanox.com>
>> Suggested-by: Ido Schimmel <idosch@mellanox.com>
>> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
>
> As a bug fix this seems relevant for 'net' instead of 'net-next'.

Sure, I'll send for net.

Thanks,
Petr