From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Machata Subject: Re: [PATCH net-next 1/9] net: ndo_bridge_setlink: Add extack Date: Wed, 12 Dec 2018 13:58:26 +0000 Message-ID: References: <2eefe68d8d5441b25eb9a75570c4725877e117b6.1544614445.git.petrm@mellanox.com> <9121d1c9-122e-a45e-4c51-9df7e8e06f9c@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "netdev@vger.kernel.org" , Jiri Pirko , Ido Schimmel , "davem@davemloft.net" , "ivecera@redhat.com" To: Nikolay Aleksandrov Return-path: Received: from mail-eopbgr140089.outbound.protection.outlook.com ([40.107.14.89]:44526 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726245AbeLLN6a (ORCPT ); Wed, 12 Dec 2018 08:58:30 -0500 In-Reply-To: <9121d1c9-122e-a45e-4c51-9df7e8e06f9c@cumulusnetworks.com> (Nikolay Aleksandrov's message of "Wed, 12 Dec 2018 14:26:48 +0200") Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Nikolay Aleksandrov writes: > On 12/12/2018 13:52, Petr Machata wrote: >> int (*ndo_bridge_setlink)(struct net_device *dev, >> struct nlmsghdr *nlh, >> - u16 flags); >> + u16 flags, >> + struct netlink_ext_ack * >> + extack); > > IMO it's better to have struct netlink_ext_ack and extack on the same > line even if it goes a little over 80 here, it is normal for netdevice > ops and wouldn't be the first (check below or above). At first I thought > the arg name is missing. :) Yeah, I didn't really like this either. It would be 86, which is the reason I broke it like this, but it's not the longest declaration in that file. I'll fold it like you propose.