From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Machata <petrm@mellanox.com>
Subject: Re: [PATCH net-next 1/7] net: ipv4: Control SKB reprioritization after forwarding
Date: Tue, 31 Jul 2018 17:01:15 +0300
Message-ID: <wihr2jj1p3o.fsf@dev-r-vrt-156.mtr.labs.mlnx>
References: <cover.1533030830.git.petrm@mellanox.com>
        <56e17ee7750b89ff350735ff7cbaf14c63864586.1533030830.git.petrm@mellanox.com>
        <5746599c-64b1-f283-cb15-b980605cb704@cumulusnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kselftest@vger.kernel.org, davem@davemloft.net,
        corbet@lwn.net, jiri@mellanox.com, idosch@mellanox.com,
        kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, shuah@kernel.org,
        dsahern@gmail.com
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr20081.outbound.protection.outlook.com ([40.107.2.81]:31552
        "EHLO EUR02-VE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1732173AbeGaPmb (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 31 Jul 2018 11:42:31 -0400
In-Reply-To: <5746599c-64b1-f283-cb15-b980605cb704@cumulusnetworks.com>
        (Nikolay Aleksandrov's message of "Tue, 31 Jul 2018 16:50:12 +0300")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Nikolay Aleksandrov <nikolay@cumulusnetworks.com> writes:

>> diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
>> index f2a0a3bab6b5..d3cfbd89ca3a 100644
>> --- a/net/ipv4/af_inet.c
>> +++ b/net/ipv4/af_inet.c
>> @@ -1802,6 +1802,7 @@ static __net_init int inet_init_net(struct net *net)
>>  	 * We set them here, in case sysctl is not compiled.
>>  	 */
>>  	net->ipv4.sysctl_ip_default_ttl = IPDEFTTL;
>> +	net->ipv4.sysctl_ip_fwd_update_priority = true;
>
> nit: since this is an int and to keep the code style of inet_init_net()
>      I'd suggest to use 1 instead

OK.

Thanks,
Petr