From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Machata Subject: Re: [PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events Date: Tue, 29 May 2018 17:37:30 +0300 Message-ID: References: <708f594ac6cef4a63a6f6a28759098c4d7922976.1527503302.git.petrm@mellanox.com> <20180529102543.GA1883@apalos> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, bridge@lists.linux-foundation.org, jiri@mellanox.com, idosch@mellanox.com, davem@davemloft.net, razvan.stefanescu@nxp.com, gregkh@linuxfoundation.org, stephen@networkplumber.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, nikolay@cumulusnetworks.com To: Ilias Apalodimas Return-path: Received: from mail-eopbgr10046.outbound.protection.outlook.com ([40.107.1.46]:51840 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934608AbeE2Ohz (ORCPT ); Tue, 29 May 2018 10:37:55 -0400 In-Reply-To: <20180529102543.GA1883@apalos> (Ilias Apalodimas's message of "Tue, 29 May 2018 13:25:43 +0300") Sender: netdev-owner@vger.kernel.org List-ID: Ilias Apalodimas writes: >> diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c >> index e73e4fe..aeafdb9 100644 >> --- a/drivers/net/ethernet/rocker/rocker_main.c >> +++ b/drivers/net/ethernet/rocker/rocker_main.c >> @@ -1632,6 +1632,9 @@ rocker_world_port_obj_vlan_add(struct rocker_port *rocker_port, >> { >> struct rocker_world_ops *wops = rocker_port->rocker->wops; >> >> + if (netif_is_bridge_master(vlan->obj.orig_dev)) >> + return -EOPNOTSUPP; >> + > What will happen to the "bridge vlan add dev br0 vid X pvid untagged self" when > the lower level (the driver) returns -EOPNOTSUPP? Will it avoid adding a vlan on > the bridge ? No, it will still do it. The reasons are: - that's what currently happens anyway: none of the drivers has any support, yet the bridge logic is done - -EOPNOTSUPP is what switchdev_port_obj_*() return if switchdev is not compiled in In order to suppress the setting, return e.g. -EINVAL: # bridge vlan add dev br vid 111 self RTNETLINK answers: Invalid argument # bridge vlan show dev br port vlan ids br 1 PVID Egress Untagged Thanks, Petr