From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Machata <petrm@mellanox.com>
Subject: Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs
Date: Fri, 25 May 2018 20:00:37 +0300
Message-ID: <wihwovrfz62.fsf@dev-r-vrt-156.mtr.labs.mlnx>
References: <cover.1527173527.git.petrm@mellanox.com>
        <b0b6b46a239eb330d722cea89137ab6ec5bae6e3.1527173527.git.petrm@mellanox.com>
        <877enrzp42.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain
Cc: <netdev@vger.kernel.org>, <devel@driverdev.osuosl.org>,
        <bridge@lists.linux-foundation.org>, <jiri@mellanox.com>,
        <idosch@mellanox.com>, <davem@davemloft.net>,
        <razvan.stefanescu@nxp.com>, <gregkh@linuxfoundation.org>,
        <stephen@networkplumber.org>, <andrew@lunn.ch>,
        <f.fainelli@gmail.com>, <nikolay@cumulusnetworks.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-he1eur01on0065.outbound.protection.outlook.com ([104.47.0.65]:37062
        "EHLO EUR01-HE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S934549AbeEYRBB (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 25 May 2018 13:01:01 -0400
In-Reply-To: <877enrzp42.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
        (Vivien Didelot's message of "Fri, 25 May 2018 12:17:33 -0400")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:

>> +	} else {
>> +		err = br_switchdev_port_obj_add(dev, v->vid, flags);
>> +		if (err && err != -EOPNOTSUPP)
>> +			goto out;
>>  	}
>
> Except that br_switchdev_port_obj_add taking vid and flags arguments
> seems confusing to me, the change looks good:

I'm not sure what you're aiming at. Both VID and flags are sent with the
notification, so they need to be passed on to the function somehow. Do
you have a counterproposal for the API?

Thanks,
Petr