* [PATCH v4] net/core: Replace offensive comment in skbuff.c
@ 2025-09-01 6:06 mysteryli
2025-09-01 13:32 ` Willem de Bruijn
0 siblings, 1 reply; 3+ messages in thread
From: mysteryli @ 2025-09-01 6:06 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Andrew Lunn, Simon Horman, Willem de Bruijn, Mina Almasry,
Jason Xing, Michal Luczaj, Alexander Lobakin, Eric Biggers,
netdev, linux-kernel, Mystery Li, Mystery Li
From: Mystery Li <929916200@qq.com>
The original comment contained profanity to express the frustration of
dealing with a complex and resource-constrained code path. While the
sentiment is understandable, the language is unprofessional and
unnecessary.
Replace it with a more neutral and descriptive comment that maintains
the original technical context and conveys the difficulty of the
situation without the use of offensive language.
Indeed, I do not believe this will offend any particular individual or group.
Nonetheless, it is advisable to revise any commit that appears overly emotional or rude.
Signed-off-by: "Mystery Li" <m13940358460@163.com>
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ee0274417948..202c25a01f22 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -5333,7 +5333,7 @@ int skb_cow_data(struct sk_buff *skb, int tailbits, struct sk_buff **trailer)
skb_has_frag_list(skb1)) {
struct sk_buff *skb2;
- /* Fuck, we are miserable poor guys... */
+ /* This is a painfully difficult situation with limited resources... */
if (ntail == 0)
skb2 = skb_copy(skb1, GFP_ATOMIC);
else
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v4] net/core: Replace offensive comment in skbuff.c
2025-09-01 6:06 [PATCH v4] net/core: Replace offensive comment in skbuff.c mysteryli
@ 2025-09-01 13:32 ` Willem de Bruijn
2025-09-01 18:41 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Willem de Bruijn @ 2025-09-01 13:32 UTC (permalink / raw)
To: mysteryli, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Andrew Lunn, Simon Horman, Willem de Bruijn, Mina Almasry,
Jason Xing, Michal Luczaj, Alexander Lobakin, Eric Biggers,
netdev, linux-kernel, Mystery Li, Mystery Li
mysteryli wrote:
> From: Mystery Li <929916200@qq.com>
>
> The original comment contained profanity to express the frustration of
> dealing with a complex and resource-constrained code path. While the
> sentiment is understandable, the language is unprofessional and
> unnecessary.
> Replace it with a more neutral and descriptive comment that maintains
> the original technical context and conveys the difficulty of the
> situation without the use of offensive language.
> Indeed, I do not believe this will offend any particular individual or group.
> Nonetheless, it is advisable to revise any commit that appears overly emotional or rude.
>
> Signed-off-by: "Mystery Li" <m13940358460@163.com>
You ignored the main feedback to patch v1 about invalid signed-off.
And for some reason sent the same patch again as v2 and v4.
In general old comments are left as is, even those that would perhaps
be written differently today.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] net/core: Replace offensive comment in skbuff.c
2025-09-01 13:32 ` Willem de Bruijn
@ 2025-09-01 18:41 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-09-01 18:41 UTC (permalink / raw)
To: mysteryli
Cc: Willem de Bruijn, David S . Miller, Eric Dumazet, Paolo Abeni,
Andrew Lunn, Simon Horman, Willem de Bruijn, Mina Almasry,
Jason Xing, Michal Luczaj, Alexander Lobakin, Eric Biggers,
netdev, linux-kernel, Mystery Li
On Mon, 01 Sep 2025 09:32:17 -0400 Willem de Bruijn wrote:
> In general old comments are left as is, even those that would perhaps
> be written differently today.
+1 please stop resending this patch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-01 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 6:06 [PATCH v4] net/core: Replace offensive comment in skbuff.c mysteryli
2025-09-01 13:32 ` Willem de Bruijn
2025-09-01 18:41 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).