From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81D1548DB49 for ; Fri, 16 Oct 2026 18:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792174635; cv=none; b=b6eGvhQJYWuhcJoRfHHCcNppcCw4LtzaVLVR/ZjHOJc48tzZwnR9tsTMBLef2z0klPyMak4+0YDqzv9VVYN5hJT45tML+6JBXrg12dA8Qz5ISL+23cW/gMwW/e50kkdTMHFdT4qHzlfJ2PgdzH1SYlyGyScuocLEoPOKPleoiYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792174635; c=relaxed/simple; bh=SBCt/eBXMWQ8dCo0YSEHtUPDvD40Qpw86uvOcqNS834=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=d14NxFh+SchbriI9XnNJ9qoIqAeyy4UqjcHJgChD4EiTHQpBwJ/xC89q5IYw9+IzuuAoyj6FlxOaaQhx5zwnkMNn2umn/BCZNCQLiyhyadZuukIcK2zp2yMvbtqtYLWQYzOajFKAmY3SLMA/giW0nBde+49HZgNXAREseKAWPbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LB3pgZ4C; arc=none smtp.client-ip=209.85.221.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LB3pgZ4C" Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-5e931215e5fso143590e0c.3 for ; Fri, 16 Oct 2026 11:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792174633; x=1792779433; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Y8u6hYFXZk0LfN+Hez4/Z5m0bA/NCutshHV861wnw+M=; b=LB3pgZ4CUJXxXMAzxjd23UwEauPagvkvYuJeVPlXl7grKK5cjddpphlzR+zMVZa12f gusrI2PfnCS4A95A/lhEhAd+APKEo1Z3sMJvOL68uMCQw8VI1GitZTFgYMhUQxbKdVFO dlV3sPd8RCEtUZM0ZU1P97yO6VVrHA78mEISl39kOOPF0DPNjtJCGW0YXYGlkLL7NOKU 0Dy2JJPKQaTpX8gFk2pqddkg5th5fYEOxTl+oBWY0yJaccycLdBGr27vRQuJQagyGFQ3 xepvZp3kbhqOBhLG2x2jGvROnddeLOA5zblXCRtBjOJCXJZsNbx8AD/xNKMd0DIFT74y xB9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792174633; x=1792779433; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y8u6hYFXZk0LfN+Hez4/Z5m0bA/NCutshHV861wnw+M=; b=xCPhtI8xnbVFJwF+YelgMdZYjVzO1RpWUscIvvY4Fone0XsNSblpXMKWWM0yhwiDKt 9ws0A7ClT7hA0AIeL7DENsxgJNy45/8kOM8VZqbUC20x+i5DHPPyPEEOsOC3hRxMsLhL dmkGYm5Cra4C2mWpkcYY09olQ2D4xMenT8CC7SKBYnX52jfsydJZHTnqdhpm2t78PtgC 6vzM3ROnDmMrPrRCVR1FYh7uK4xRl/K6nn9t95IJnAMarcaeoJFH2tMp7zp67Ldn77KI 2OKfeoHrTAHxsH1v3tGOS6oWV8FK3kl4cv1dVzJfcb0wwtxHi+auoJoZJv4PJznfIEQh 65eQ== X-Forwarded-Encrypted: i=1; AKwUvBz4rWSoNYe9cNnAhFzeDkWzZ4w/FyhExiJ/QPNLmI/C226BU9+m7S2y3eNiSakxc6LvcyQcH6o=@vger.kernel.org X-Gm-Message-State: AFq9FYIsbmy/XdoWz98BwFfqChqKddh2/uDM4GcVog/q+sb7KozHyXIj NNYmNmzKp+TkYTkv7yxNU5zoJPq1gvFXxJm1fvlkBnnEWAvFqccT2Xuq X-Gm-Gg: AYBFou3gHb6nnnxVE3uXosUJOnm+P5z7zYVivmW15rYZhkXCW9QKc61DTA0hprvuL9v /loG8zvVERIlrJpCTJiaZZ/c2x7nGtz8xhXjjNjTv4H+YTkoZ2jHFY3xqShh2r43GLNnqBrrXMF dxAGeylK8aWGA/Ak8VCqPry0Ja9t8E6sRC45lG3Y9xMmIkbYNSLwi5b/VSv7z7V/hFyTvDpDRE/ 9yWeF6riTfXwiZgf+ut2twH4suPTYgaAd6PCQ5UffvdrkHUk9WJBLitSPr9I6ESbwrCZJoOXDR+ 0+Wb4wx/xBa9VN4oUe/wLE0K5Vn10rm4sigE9FlLW+lCvonWjwIeiYoMdzJJw4XHIHjFA3xTQyj gJ+99MNjwPMQBCQXhDVAt2g71NtdnskP3hX1aOmNfKFX2/mF8zrjEUgCRmIEK7R4UCut+54T/wE ZyXBKjGbdjke08YTEAFqioN+ahIXNWVR4chR8X9JnNs/nCSO4FtikB4a/6cMTG/mfrY/uFRSFVY y7p4uz3oG2PBWxGSPfRGYB7MCuK1goAAUulD2Drm7AFCQtNBXnjwNR1zFtgU6MC+uQqEZUEb2kP YsbderjYhd5sFQMRi+UTM9f2M1xC3d1TNV7c2ulxOJpkNaJO X-Received: by 2002:a05:6102:4187:b0:7c1:94eb:d72b with SMTP id ada2fe7eead31-7cc36b23993mr155186137.34.1792174633433; Fri, 16 Oct 2026 11:17:13 -0700 (PDT) Received: from gmail.com (111.46.245.35.bc.googleusercontent.com. [35.245.46.111]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9908366328dsm2092409241.12.2026.10.16.11.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 11:17:12 -0700 (PDT) Date: Fri, 16 Oct 2026 14:17:11 -0400 From: Willem de Bruijn To: "Michael S. Tsirkin" , Willem de Bruijn Cc: linux-kernel@vger.kernel.org, Jason Wang , =?UTF-8?B?RXVnZW5pbyBQw6lyZXo=?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Rusty Russell , Max Krasnyansky , Jonathan Corbet , Shuah Khan , Randy Dunlap , Simon Horman , linux-doc@vger.kernel.org Message-ID: In-Reply-To: <20261016135328-mutt-send-email-mst@kernel.org> References: <20261016051827-mutt-send-email-mst@kernel.org> <20261016135328-mutt-send-email-mst@kernel.org> Subject: Re: [PATCH net-next v2 5/7] net: add a sysctl to opt out of virtio net hdr checksum validation Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Michael S. Tsirkin wrote: > On Fri, Oct 16, 2026 at 11:30:17AM -0400, Willem de Bruijn wrote: > > Michael S. Tsirkin wrote: > > > On Thu, Oct 15, 2026 at 01:50:54PM -0400, Willem de Bruijn wrote: > > > > Michael S. Tsirkin wrote: > > > > > The ingress validation as implemented by the previous > > > > > patch is stricter than what it replaced: GSO > > > > > packets whose checksum metadata matches no transport header are > > > > > dropped, and non-GSO ones get their checksum completed in place. > > > > > Such packets used to pass with the metadata unvalidated, > > > > > and with no overhead. > > > > > > > > > > I judge that this should not affect any deployments, but there is still > > > > > some risk that it does. In case a deployment depends on them anyway, > > > > > provide a per-netns switch to get the old behavior back: > > > > > > > > > > echo 0 > /proc/sys/net/core/virtio_net_hdr_csum_check > > > > > > > > > > The default is validating. > > > > > > > > > > Assisted-by: LLM > > > > > Signed-off-by: Michael S. Tsirkin > > > > > --- > > > > > Documentation/admin-guide/sysctl/net.rst | 15 +++++++ > > > > > include/linux/virtio_net.h | 23 ++++++++++ > > > > > include/net/netns/core.h | 1 + > > > > > net/core/dev.c | 6 +++ > > > > > net/core/net_namespace.c | 1 + > > > > > net/core/sysctl_net_core.c | 54 ++++++++++++++++++++++++ > > > > > 6 files changed, 100 insertions(+) > > > > > > > > > > diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst > > > > > index e586e17fc7a5..7f230929c37e 100644 > > > > > --- a/Documentation/admin-guide/sysctl/net.rst > > > > > +++ b/Documentation/admin-guide/sysctl/net.rst > > > > > @@ -246,6 +246,21 @@ processes are dropped unless socket option SOF_TIMESTAMPING_OPT_TSONLY is set. > > > > > Default: 1 (on) > > > > > > > > > > > > > > > +virtio_net_hdr_csum_check > > > > > +------------------------- > > > > > > > > Make more generic, virtio_net_hdr_validate? > > > > > > > > In case we add more validation in the future (as we have in the past), > > > > without having to introduce multiple such knobs. > > > > > > But it's uapi, are you sure we'll be able to change the meaning > > > of an existing knob, even if we keep the name vague? > > > > > > > > + > > > > > +When processing packets with a virtio net header (through tun, tap, a > > > > > +packet socket or a virtio network device) that request checksum offload > > > > > +(VIRTIO_NET_HDR_F_NEEDS_CSUM), validate the packet: complete the checksum > > > > > +in software, or drop the packet where the header does not match it. > > > > > + > > > > > +When disabled, the header is trusted not to corrupt the packet, and the > > > > > +checksum is offloaded to hardware (or not verified if it never reaches > > > > > +hardware). This is only safe if no protocol is processing the packets. > > > > > + > > > > > +Default: 1 (on) > > > > > + > > > > > + > > > > > wmem_default > > > > > ------------ > > > > > > > > > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > > > > > index 357115ff0ec2..aa2f8ac4657c 100644 > > > > > --- a/include/linux/virtio_net.h > > > > > +++ b/include/linux/virtio_net.h > > > > > @@ -5,6 +5,7 @@ > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -78,6 +79,19 @@ static inline struct iphdr *virtio_net_ip4_parse(struct sk_buff *skb, > > > > > *thoff = nhoff + iph->ihl * sizeof(u32); > > > > > return iph; > > > > > } > > > > > +/* Defined in net/core/dev.c, enabled while any network namespace > > > > > + * has net.core.virtio_net_hdr_csum_check set to 0. > > > > > + */ > > > > > > > > Should this be a global sysctl, rather than per netns? > > > > > > > > > For customers I work with, it would be much less useful. > > > > Third option: make it an integer rather than a boolean. > > > > 0: no validation > > 1: current level of validation > > 2 and beyond: if we have to extend it later > > > Oh that's an interesting idea. Issue: userspace learns about 1, then > someone sets it to 1 thinking this is the highest level and in fact > disables some security. True. If concerned about that we could change the interpretation, keep 1 the highest, subsequent for legacy.