From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Wang Zhan <wang.zhan@smartx.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, keyong.sun@smartx.com,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowangio@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
dev@openvswitch.org, Daniel Borkmann <daniel@iogearbox.net>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Alice Mikityanska <alice@isovalent.com>,
David Laight <david.laight.linux@gmail.com>,
Wang Zhan <wang.zhan@smartx.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v5 4/6] net: gso: clear the GSO state of the last output segment
Date: Thu, 08 Oct 2026 14:37:58 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.144d1171e4ef@gmail.com> (raw)
In-Reply-To: <20261008100651.2534957-5-wang.zhan@smartx.com>
Wang Zhan wrote:
> skb_segment() clears gso_size on the last output of a group which holds one
> MSS or less, but leaves gso_segs and gso_type as the grouping set them, so
> the tail is still counted as the whole group. Readers which take gso_segs
> without testing gso_size first, such as the ECT statistics in ip_rcv_core()
> and tp->rcv_ooopack in tcp_rcv_established(), see that stale count, and a
> re-segmented output reaches them when a veth or bridge port delivers it back
> into the receive path.
>
> Clear gso_size, gso_segs and gso_type together with skb_gso_reset().
>
> Suggested-by: Willem de Bruijn <willemb@google.com>
> Assisted-by: LLM
> Signed-off-by: Wang Zhan <wang.zhan@smartx.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2026-10-08 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:06 [PATCH net-next v5 0/6] net: re-segment oversized TCP GSO skbs Wang Zhan
2026-10-08 10:06 ` [PATCH net-next v5 1/6] net: core: use the packet's L3 protocol for the GSO size limit Wang Zhan
2026-10-08 10:06 ` [PATCH net-next v5 2/6] net: core: factor out the GSO device limit check Wang Zhan
2026-10-08 10:06 ` [PATCH net-next v5 3/6] net: gso: support re-segmentation of TCP GSO skbs Wang Zhan
2026-10-08 10:06 ` [PATCH net-next v5 4/6] net: gso: clear the GSO state of the last output segment Wang Zhan
2026-10-08 18:37 ` Willem de Bruijn [this message]
2026-10-08 10:06 ` [PATCH net-next v5 5/6] net: core: re-segment oversized TCP GSO skbs Wang Zhan
2026-10-08 10:06 ` [PATCH net-next v5 6/6] net: net_test: add tests for TCP re-segmentation Wang Zhan
2026-10-08 18:38 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.144d1171e4ef@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=aconole@redhat.com \
--cc=alice@isovalent.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jasowangio@gmail.com \
--cc=keyong.sun@smartx.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wang.zhan@smartx.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox