From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0452F99BD for ; Sat, 7 Mar 2026 23:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772927615; cv=none; b=oGqGPiqyJKvOn7EGk2qDKBPzxXBwkhXF1TvmgtnaEuE/eCL/dPypOB2wflh2FeqblZMQ+96poYiNMd0Z0bBPju6O1BFR9VeTKfz+4N17y5LbthW67WZK1M97K+VTvVcTTBIeHTdOzVGrL7WECwPCeIPvAsKrxy8V8VLctCuHE/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772927615; c=relaxed/simple; bh=Rp5I6tnZ9KHNuigV2xCxO3JX6po9/jbB8s8mZoIUD0E=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=WUpUSdta5uLoZOhKh9vccKkC/4PETKh+yDu8AquMhflYQFssV4ZrCaaxh+pv8xnc/qxnMkBGOvvIsCnWWP4RM5m9JHz5GcqsvN7HF43TKml6asT2F9Sh9GTqBq1RJZ/0AhHw6XoooI86WrnUx7fD4XqFXF4cwBYvsCfFoAinUYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g228k7k9; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g228k7k9" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-7982c3b7dfcso105723907b3.0 for ; Sat, 07 Mar 2026 15:53:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772927613; x=1773532413; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KrVted/9LPdxywvkSCrfMXaTaDdzZiGs4BC17n8m8NE=; b=g228k7k9cb6ud/HEy/I0GNYuuDXax+psv6A4xQoUsT9j3NRBaM2/KOKYa1NEQ1M0QL nl7AGjZ/zO+x62jg958PN5DieYD4LyyuKpgaMWTtDTnkPA1Cv7/wQK7vEKu321t0UewE elMekat21dk7Lh2OsnT/0080WTDdvTc7jmC7PRhkyysO373aSJPeUmaPRziQClKMoWEC 07dRpnPLbTeTt/yWI7d7/SQ/k3eS9qqpdk3Llm/OkkJfB1InibcjAwPubdcH1pyoPUQh xmcbo92iyt3pcajqjrE/NrBZOoYIi2V7C/VfYsxeMOsIDIIp1cUSlSz9fRYejOAxhjZD gYLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772927613; x=1773532413; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KrVted/9LPdxywvkSCrfMXaTaDdzZiGs4BC17n8m8NE=; b=jnHEPb6cb6h1IgfGLLJWqRQ+cixiiRgBfeDg9YMOtJYl6MUQ2ZksOk7qusVmsL37gV 9jpkxvZTPJTTIVygyL5z8PafNZz6QH9yK/aYAO5IC2i9OBEEWk9B6y60RufzfGnUxSGT cJrDB7yWn2evoYuTMud+uORQjipHj5y/DTdA67DKhHpBDqASZcf5Kxbdrx/8XX7mtGaP 6F4RRyFUVISL4LVGf9/XhS7EqJtUIptGtU0drTJCrC9XARQf/JFYoVSjPJgpLMda0Khq FFaickmLCfVOkuTESa+iUJw28gxOcLZQBAI8VesbQeD844aSmDMSbXxdvETXreL29aj3 QBSw== X-Forwarded-Encrypted: i=1; AJvYcCVBRUbvMIi7vFBJUFZ3PyRm+4hWcCqhxVMQsuRTUrJiqXcUw1f0UsTlH+85VubfzGomu5lZyjA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu7J4pBtmPc2b5SrYGJB3CxYYBMOloA6693i1zEedRwcM4o7Vm mea0umdN7+rtcWIdWx2CK8uVUqN72qUlalFbLSZLjfJ2S9seTxVDneJk X-Gm-Gg: ATEYQzyDFi7rFQtDvd1uhKZUXrwYLwox/g9GeR1Vz6BQUW9plIOnzv6elmRuCD/R2Ki ybinB10pwsJEve08dJPpaIyBKg5cjOvDERU47C7+Ztxzelsfr7MifMpYyCuNB7b9PYEl7TCxavq ved+cu6odewJ/9WOI7nXSpARopapUKayQfcfn7Gh+xBych3IOCSJYXyS3RHw3C41AeqJZZCKARc B3dZeFyY8bs8eiZr6Vb1p2kSf+HdqUU2NDig5O+cPVYBquH8M8TxwHUWZ2v3V6CgIiXUoQqq0yT LBD4ecEQPg95PKCUELd8/jFMjt+ZkO7zK3IU0NEfH3kiZ5wKTYZ5HTlorpGHawaqF35uL6LqgAx 7nZR2sieYCAqDdOSTbE7jw5bfrbvhLoQkaSEotC4qLeCSmgRs+DCJOLxUXn6EsiM+NExbMIFzvo 1+GL+xOz66xdsD9yzGgmIdP7A8oWtRKeMb5Tf9ajlt+CaIRneacW9nK5RvbEr5TGWne06801Tks RgR8//cMg== X-Received: by 2002:a05:690c:1d:b0:798:1636:c330 with SMTP id 00721157ae682-798dd756762mr64965377b3.34.1772927613482; Sat, 07 Mar 2026 15:53:33 -0800 (PST) Received: from gmail.com (15.60.86.34.bc.googleusercontent.com. [34.86.60.15]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-798dee68c47sm25656727b3.43.2026.03.07.15.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 15:53:32 -0800 (PST) Date: Sat, 07 Mar 2026 18:53:32 -0500 From: Willem de Bruijn To: Alice Mikityanska , Willem de Bruijn Cc: Alice Mikityanska , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Xin Long , David Ahern , Nikolay Aleksandrov , Shuah Khan , Stanislav Fomichev , Andrew Lunn , Simon Horman , Florian Westphal , netdev@vger.kernel.org, Gal Pressman Message-ID: In-Reply-To: References: <20260226201600.222044-1-alice.kernel@fastmail.im> <20260226201600.222044-3-alice.kernel@fastmail.im> Subject: Re: [PATCH net-next v2 02/12] udp: gso: Simplify handling length in GSO_PARTIAL Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Alice Mikityanska wrote: > On Sun, 8 Mar 2026 at 01:23, Willem de Bruijn > wrote: > > > > Alice Mikityanska wrote: > > > Thanks for reviewing my series! > > > > > > On Fri, 6 Mar 2026 at 22:55, Willem de Bruijn > > > wrote: > > > > > > > > Alice Mikityanska wrote: > > > > > From: Alice Mikityanska > > > > > > > > > > Taking further the idea of commit b10b446ce7ad ("udp: gso: Use single > > > > > MSS length in UDP header for GSO_PARTIAL"), simplify the implementation > > > > > and fix the checksum (apparently ignored by hardware anyway). > > > > > > > > > > The mentioned commit started using msslen for uh->len, but still uses > > > > > newlen to adjust uh->check. If the formula for check is fixed, newlen is > > > > > assigned but never used before the loop, and newlen is overwritten after > > > > > the loop. This makes msslen not really necessary, as we can reuse > > > > > newlen, if we don't adjust mss before. > > > > > > > > That's a big if. Why is the udp length now set to the segment length, > > > > and not to the GSO packet length, as before? > > > > > > Just so that we are on the same page: the behavior of the UDP length > > > field changed in Gal's commit b10b446ce7ad, not in mine. You reviewed > > > that commit and approved it: > > > > > > https://lore.kernel.org/netdev/willemdebruijn.kernel.218d53621fba7@gmail.com/ > > > > > > I'm just refactoring to simplify the code a little bit + fixing the > > > checksum field that went out of sync with length after Gal's change. > > > Hope that clarifies it. > > > > Oh right. When respinning can you add this brief summary? > > It's already in the first sentence of the commit message... I can > rephrase it to add something about "refactoring without changing > behavior" if "simplify the implementation" reads ambiguous. I totally read over that. As is is great. Thanks.