Re: [PATCH net] net: extend virtio_net_hdr csum_start checks to VLAN, IPv6 and IP options

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

netdev-bot+sashiko@ wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 2 · Medium: 1 · Low: 0 (1)
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The fix leaves the UDP-tunnel path, virtio_net_hdr_tnl_to_skb()
>   in include/linux/virtio_net.h, with the same weakness it removes from…
> - [High] virtio_net_hdr_thoff_valid() decides whether skb->data starts
>   with an Ethernet header only from `skb->dev->type == ARPHRD_ETHER`…
> - [Medium] On the non-ARPHRD_ETHER branch, virtio_net_hdr_thoff_valid()
>   leaves proto = 0 and then guesses the L3 protocol from the version…

All comments look valid and require a respin. Any revision will take
them into account.

Based also on the previous conversation in this thread, will review the
approach. Updated in patchwork to changes requested.