From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Rongguang Wei <clementwei90@163.com>, netdev@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com, jasowangio@gmail.com,
andrew+netdev@lunn.ch, Rongguang Wei <weirongguang@kylinos.cn>,
andrew@daynix.com
Subject: Re: [PATCH net v1] tap: fix incorrect variable used for USO check in set_offload()
Date: Wed, 05 Aug 2026 09:34:50 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.1dd05d081b77d@gmail.com> (raw)
In-Reply-To: <20260805072121.117472-1-clementwei90@163.com>
Rongguang Wei wrote:
> From: Rongguang Wei <weirongguang@kylinos.cn>
>
> The USO features in set_offload() incorrectly uses feature_mask
> instead of arg argument.
>
> TUN_F_USO4 and TUN_F_USO6 belong to the TUN_F_* flag, while feature_mask
> belong to NETIF_F_* values (NETIF_F_HW_CSUM, NETIF_F_TSO, etc.) and
> will never contain any TUN_F_* bits.
>
> Fixes: 399e0827642f ("driver/net/tun: Added features for USO.")
> Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2026-08-05 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 7:21 [PATCH net v1] tap: fix incorrect variable used for USO check in set_offload() Rongguang Wei
2026-08-05 13:34 ` Willem de Bruijn [this message]
2026-08-06 16:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1dd05d081b77d@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@daynix.com \
--cc=clementwei90@163.com \
--cc=jasowangio@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=weirongguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox