From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: netdev-bot+sashiko@kernel.org, willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
andrew+netdev@lunn.ch, willemb@google.com
Subject: Re: [PATCH net-next v2] selftests: net: csum: filter packets by source address and port
Date: Mon, 07 Sep 2026 22:01:50 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.1ff5ab9efe897@gmail.com> (raw)
In-Reply-To: <178876110986.219967.12438774212046389670@kernel.org>
netdev-bot+sashiko@ wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> - [Medium] The newly added source-port filter is silently disabled for
> the `-Z` (zero-checksum) configuration in both receive paths, leaving…
>
>
> [Severity: Medium]
> Could the !cfg_zero_sum condition in recv_udp() and in
> recv_verify_packet_udp() get a comment, or be replaced by computing the
> expected port on the receiver?
Fair. For -Z, I'll have the receiver call build_packet() too, so that
build_packet_udp() updates cfg_port_src to the expected value.
prev parent reply other threads:[~2026-09-08 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 3:04 [PATCH net-next v2] selftests: net: csum: filter packets by source address and port Willem de Bruijn
2026-09-07 6:05 ` netdev-bot+sashiko
2026-09-08 2:01 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1ff5ab9efe897@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox