public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xu Du <xudu@redhat.com>,  Jakub Kicinski <kuba@kernel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	 davem@davemloft.net,  edumazet@google.com,  pabeni@redhat.com,
	 horms@kernel.org,  shuah@kernel.org,  netdev@vger.kernel.org,
	 linux-kselftest@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/8] selftest: Extend tun/virtio coverage for GSO over UDP tunnel
Date: Wed, 07 Jan 2026 09:59:36 -0500	[thread overview]
Message-ID: <willemdebruijn.kernel.24d5d52e43030@gmail.com> (raw)
In-Reply-To: <CAA92KxkOYKA9vsihvk0FR58m4zgM8-oZVWGsLDYycnk4UWmQAg@mail.gmail.com>

Xu Du wrote:
> On Wed, Jan 7, 2026 at 6:58 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Tue, 06 Jan 2026 17:14:05 -0500 Willem de Bruijn wrote:
> > > For instance, can the new netlink code be replaced by YNL, whether in
> > > C or called from a script?
> >
> > +1 looks like YNL is already used in net/ tests, and it supports
> > the operations in question, so that's a much better direction.
> > Please let us (YNL maintainers) know if there's anything missing
> > or not working, IDK how much use the rtnetlink support in YNL is
> > getting.
> >
> 
> Thank you for the suggestion. I am looking into replacing the netlink
> with YNL to reduce code. But after reviewing rt-link.rst, I found that
> rt-link currently lacks support for VXLAN. Would more significant changes
>  to the patch be acceptable if I switch to Geneve to leverage YNL?

These are only changes to the new code in your series. SGTM. I assume
it is not a significant burden as the two are fairly similar. Is that
correct?

Eventually it may be nice to have VXLAN support in YNL akin to Geneve
support. But sounds like a separate goal.

  reply	other threads:[~2026-01-07 14:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06  1:35 [PATCH net-next v4 0/8] selftest: Extend tun/virtio coverage for GSO over UDP tunnel Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 1/8] selftest: tun: Format tun.c existing code Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 2/8] selftest: tun: Introduce tuntap_helpers.h header for TUN/TAP testing Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 3/8] selftest: tun: Refactor tun_delete to use tuntap_helpers Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 4/8] selftest: tap: Refactor tap test " Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 5/8] selftest: tun: Add helpers for GSO over UDP tunnel Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 6/8] selftest: tun: Add test for sending gso packet into tun Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 7/8] selftest: tun: Add test for receiving gso packet from tun Xu Du
2026-01-06  1:35 ` [PATCH net-next v4 8/8] selftest: tun: Add test data for success and failure paths Xu Du
2026-01-06  1:57 ` [PATCH net-next v4 0/8] selftest: Extend tun/virtio coverage for GSO over UDP tunnel Jakub Kicinski
2026-01-06  2:17   ` Xu Du
2026-01-06 22:14 ` Willem de Bruijn
2026-01-06 22:58   ` Jakub Kicinski
2026-01-07 10:08     ` Xu Du
2026-01-07 14:59       ` Willem de Bruijn [this message]
2026-01-08  2:09         ` Xu Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.24d5d52e43030@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=xudu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox