Re: [PATCH net-next v8 3/6] idpf: support pacing offload

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

netdev-bot+sashiko@ wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
> 
> - [Medium] Divergent EDT state across a hard reset: the netdev-side
>   pacing horizon survives while the adapter-side timestamp granularity…

The main AI feedback to this series continues to be that the
offload_horizon can remain set after a device reset would modify the
max_offload_horizon. That is mentioned as a known caveat in the
commit message. But indeed we can do better.

For v9

- I will reset the device offload_horizon here as suggested:
  Disable offload_horizon if the new max_offload_horizon is lower.

- Am considering a device notifier in FQ to do the same for
  q->offload_horizon.

Having both a configurable dev->offload_horizon and q->offload_horizon
is perhaps overkill. But we need the new dev one to safely roll out
the idpf feature default off. We cannot rely on FQ alone, as there are
other paths to pass packets with txtime to the driver: SO_TXTIME, BPF,
ETF.

For the other feedback, also for v9:

- Will restrict the 'expect_fail = None' to the new tests that need it.

- Will address the few other low severity points.