From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D9EF3702FA for ; Tue, 18 Nov 2025 22:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763505115; cv=none; b=oR2f/2hhmZarcueSUexGHqxtOZEtWLPSZH5ity+GDZZyedeCM/okflKTDvLSuXadb39UDfRtOy/zmJuTTo56gxGIc727HzDhXuTFQ/gTU3lU38FPJKAt4/ZgEqx8Issa76fnSyOOfvQXUOhBRGjitWBboseE4Sqh1jVa/sm8brY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763505115; c=relaxed/simple; bh=7u5rSjHo75NoOI+UxqrKNBpVfXmfdqSPOBdIH6YXSBk=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=sq8c9fFbeI3n6LBwX/vt+Tv3PwH2mAOjethMMPr8KdMnrYY9W7wY7V2pHYeSWbHx8Te9+R3eWx7pQ1H17upltdaqJKPEenYaJimHDhiRQIlVAaoUAUusVcLD59ESB3ygbuRxangq9bps0zykC0W6Q+RRT0WD8bO4FkGFFYRaXJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LdIqwixy; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LdIqwixy" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-63f97ab5cfcso5126842d50.0 for ; Tue, 18 Nov 2025 14:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763505112; x=1764109912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=swHg83nqxZF6Fleu7P846/7OxC4U2kUKOxQR3ccIoBE=; b=LdIqwixye5YkcofuTgJd2r4IO9MYZ1y37konROme9sjXgCn/mO55uXD1b+ffVuqHp+ 1gDUeedfELGEidPmXLchk2ns1K4B9NBUi7CJSpgTBr7dAuoH2GLcCZyp33nUcqH1bt4w pCdZV6PrcXdmXit/kld8D9Q8pmSmS5W+YAmqo1tf2IrrIOQTGI9ZHAzsvv+Tz6A7y13R k7XhaeL+zPCHZ910L4BAtP49+134SiMy3Ax9OcCxD9DKSFLl5UrkRTQoDt5yTN/HIvvn 7uFPqC7U99rjZ1mcMnaUhyDxKF7epxUko+ex0mUI3iexPknmuwNzJ0Dutpr7ndcbHsEP kOkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763505112; x=1764109912; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=swHg83nqxZF6Fleu7P846/7OxC4U2kUKOxQR3ccIoBE=; b=h7vQDAITkHtDZEnySRhjMLEn+AJcKwVXvpa+3T3LyT/DC/fEBU3frs750amVZWpZNk BogPsLpl88ZpQ1DZd858GNj8B897T/kyC7FkdfG34oMqOENPXrLAs21vya3vLunL2Cfv BU1IyV2N73OWHKCompSNkND2dQpjjusPvT6H25Au74c/Urz3MahPZJUyBpsRzBbvl8Ye NjpPdcWRUA8Mv+duM7o8jgwo6kIMSoYadAdGN5bJmOZp3S75mQb0luJLYWb/zj/8VSiZ yWq2vesOgtMKPJiVtV+CSlnaNIDGKf9/42NHOogeNG/fwiNYywL/hoFtrVwsRKEvq6GH Z9hw== X-Gm-Message-State: AOJu0YxiTZZOHMGcbC7HL93/gttyHbpBBnrtSVmhbLFprSj+TgTzxvV1 pbgW6y7UDt+3tuvYDweBnHjHhYnEtFDCjx6Bi9tpepbEHR7npvYOompH X-Gm-Gg: ASbGncs2RdkFpkO+/DlHcLM3o+3/lnvKQ4E9/ubr+cHBuqXkFCWs7MDQqnVgiKuNcYD ScVMyPoq9K7D9ZQBQoloJtJXCH26NgmovFgBW/Q8PBKjo9u1dlgtkyAH5sqTTgbwVd8TC2cV8pc gYBYtVya+6dX9KZypMFzm2HiGvmq3GEd28PV5TmEry+9e9Q2M7ypneIqALFgKpuQNKydUwibPol P4TVynVy9pFPUWVsHp/BPxw93jvrQS0iEWAOUFdy40OZk6Ok6pb8PPoKlXPmuun2CofCXoA4yw6 7ZtQsxKdjDmqqFvPSgWRWsK5PiDRMFKdWlCVYnOYchCeHfuvSBLnXCrVwTkYOLgUYUMtDCPGth3 aktDZFuBbiS4BeocMW6iPz0+BhKIYJKl/bkFIr08Z4ItsloWbNz61IER0DYK7t0rpfVF9Ssa3Rc yq4hmQG5QuwurM6ObKpqE3WIlWOaT7BjzcUeCnxaDQYexXVjwrvWymZ8Uf8G6zzgdrF5I= X-Google-Smtp-Source: AGHT+IG9T83KTfCCjwEaqLX0kM2I3yUkPGht8w5fKsyEevMjwg4abeuC0L5IwFmtt2cabCDX6MSt4g== X-Received: by 2002:a53:c059:0:10b0:640:b8ef:b777 with SMTP id 956f58d0204a3-641e76dd131mr11699937d50.69.1763505112433; Tue, 18 Nov 2025 14:31:52 -0800 (PST) Received: from gmail.com (116.235.236.35.bc.googleusercontent.com. [35.236.235.116]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-6410ead559dsm6273060d50.24.2025.11.18.14.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 14:31:51 -0800 (PST) Date: Tue, 18 Nov 2025 17:31:50 -0500 From: Willem de Bruijn To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, willemdebruijn.kernel@gmail.com, shuah@kernel.org, sdf@fomichev.me, krakauer@google.com, linux-kselftest@vger.kernel.org, petrm@nvidia.com, matttbe@kernel.org, Jakub Kicinski Message-ID: In-Reply-To: <20251118215126.2225826-1-kuba@kernel.org> References: <20251118215126.2225826-1-kuba@kernel.org> Subject: Re: [PATCH net-next v2 00/12] selftests: drv-net: convert GRO and Toeplitz tests to work for drivers in NIPA Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Jakub Kicinski wrote: > Main objective of this series is to convert the gro.sh and toeplitz.sh > tests to be "NIPA-compatible" - meaning make use of the Python env, > which lets us run the tests against either netdevsim or a real device. > > The tests seem to have been written with a different flow in mind. > Namely they source different bash "setup" scripts depending on arguments > passed to the test. While I have nothing against the use of bash and > the overall architecture - the existing code needs quite a bit of work > (don't assume MAC/IP addresses, support remote endpoint over SSH). > If I'm the one fixing it, I'd rather convert them to our "simplistic" > Python. > > This series rewrites the tests in Python while addressing their > shortcomings. The functionality of running the test over loopback > on a real device is retained but with a different method of invocation > (see the last patch). > > Once again we are dealing with a script which run over a variety of > protocols (combination of [ipv4, ipv6, ipip] x [tcp, udp]). The first > 4 patches add support for test variants to our scripts. We use the > term "variant" in the same sense as the C kselftest_harness.h - > variant is just a set of static input arguments. > > Note that neither GRO nor the Toeplitz test fully passes for me on > any HW I have access to. But this is unrelated to the conversion. > This series is not making any real functional changes to the tests, > it is limited to improving the "test harness" scripts. > > v2: > [patch 5] fix accidental modification of gitignore > [patch 8] fix typo in "compared" > [patch 9] fix typo I -> It > [patch 10] fix typoe configure -> configured > v1: https://lore.kernel.org/20251117205810.1617533-1-kuba@kernel.org > > Jakub Kicinski (12): > selftests: net: py: coding style improvements > selftests: net: py: extract the case generation logic > selftests: net: py: add test variants > selftests: drv-net: xdp: use variants for qstat tests > selftests: net: relocate gro and toeplitz tests to drivers/net > selftests: net: py: support ksft ready without wait > selftests: net: py: read ip link info about remote dev > netdevsim: pass packets thru GRO on Rx > selftests: drv-net: add a Python version of the GRO test > selftests: drv-net: hw: convert the Toeplitz test to Python > netdevsim: add loopback support > selftests: net: remove old setup_* scripts For the series: Reviewed-by: Willem de Bruijn