From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
andrew@lunn.ch, mohsin.bashr@gmail.com,
Willem de Bruijn <willemb@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Joshua A Hay <joshua.a.hay@intel.com>
Subject: Re: [PATCH net-next v3 3/7] idpf: support pacing offload
Date: Tue, 28 Jul 2026 07:49:59 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.28d1bc6099571@gmail.com> (raw)
In-Reply-To: <20260727165403.268e6e4f@kernel.org>
Jakub Kicinski wrote:
> On Sun, 26 Jul 2026 16:28:47 -0400 Willem de Bruijn wrote:
> > If skb->tstamp is in the future, program this future delivery txtime
> > in the transmit descriptor.
> >
> > TCP pacing offload is only offloaded if SK_PACING_FQ is negotiated and
> > the FQ offload_horizon is configured.
>
> Hm, you're not even acting on the activation of the feature via ethtool.
> What am I missing...
Activation is only picked up on qdisc add/change.
In those lines you pointed out as less than elegant.
next prev parent reply other threads:[~2026-07-28 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 20:28 [PATCH net-next v3 0/7] hardware pacing offload Willem de Bruijn
2026-07-26 20:28 ` [PATCH net-next v3 1/7] net: ethtool: add hardware pacing offload support to rings Willem de Bruijn
2026-07-27 23:51 ` Jakub Kicinski
2026-07-28 11:45 ` Willem de Bruijn
2026-07-27 23:55 ` Jakub Kicinski
2026-07-26 20:28 ` [PATCH net-next v3 2/7] net_sched: sch_fq: clear past skb->tstamp if offloading pacing Willem de Bruijn
2026-07-26 20:28 ` [PATCH net-next v3 3/7] idpf: support pacing offload Willem de Bruijn
2026-07-27 23:54 ` Jakub Kicinski
2026-07-28 11:49 ` Willem de Bruijn [this message]
2026-07-26 20:28 ` [PATCH net-next v3 4/7] selftests: drv-net: refactor so_txtime errqueue handling Willem de Bruijn
2026-07-26 20:28 ` [PATCH net-next v3 5/7] selftests: drv-net: in so_txtime tell apart sw from hw pacing Willem de Bruijn
2026-07-26 20:28 ` [PATCH net-next v3 6/7] selftests: drv-net: extend so_txtime with hw offload Willem de Bruijn
2026-07-26 20:28 ` [PATCH net-next v3 7/7] net: pktgen: add support for SO_TXTIME Willem de Bruijn
2026-07-27 23:57 ` [PATCH net-next v3 0/7] hardware pacing offload Jakub Kicinski
2026-07-28 12:03 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.28d1bc6099571@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox