From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 03/13] selftest: packetdrill: Define common TCP Fast Open cookie.
Date: Sun, 28 Sep 2025 14:10:07 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.2e545b6e6e601@gmail.com> (raw)
In-Reply-To: <20250927213022.1850048-4-kuniyu@google.com>
Kuniyuki Iwashima wrote:
> TCP Fast Open cookie is generated in __tcp_fastopen_cookie_gen_cipher().
>
> The cookie value is generated from src/dst IPs and a key configured by
> setsockopt(TCP_FASTOPEN_KEY) or net.ipv4.tcp_fastopen_key.
>
> The default.sh sets net.ipv4.tcp_fastopen_key, and the original packetdrill
> defines the corresponding cookie as TFO_COOKIE in run_all.py. [0]
tiny, not reason for respin: no link [0].
> Then, each test does not need to care about the value, and we can easily
> update TFO_COOKIE in case __tcp_fastopen_cookie_gen_cipher() changes the
> algorithm.
>
> However, some tests use the bare hex value for specific IPv4 addresses
> and do not support IPv6.
>
> Let's define the same TFO_COOKIE in ksft_runner.sh.
>
> We will replace such bare hex values with TFO_COOKIE except for a single
> test for setsockopt(TCP_FASTOPEN_KEY).
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
next prev parent reply other threads:[~2025-09-28 18:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-27 21:29 [PATCH v2 net-next 00/13] selftest: packetdrill: Import TFO server tests Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 01/13] selftest: packetdrill: Set ktap_set_plan properly for single protocol test Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 02/13] selftest: packetdrill: Require explicit setsockopt(TCP_FASTOPEN) Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 03/13] selftest: packetdrill: Define common TCP Fast Open cookie Kuniyuki Iwashima
2025-09-28 18:10 ` Willem de Bruijn [this message]
2025-09-28 19:12 ` Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 04/13] selftest: packetdrill: Import TFO server basic tests Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 05/13] selftest: packetdrill: Add test for TFO_SERVER_WO_SOCKOPT1 Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 06/13] selftest: packetdrill: Add test for experimental option Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 07/13] selftest: packetdrill: Import opt34/fin-close-socket.pkt Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 08/13] selftest: packetdrill: Import opt34/icmp-before-accept.pkt Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 09/13] selftest: packetdrill: Import opt34/reset-* tests Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 10/13] selftest: packetdrill: Import opt34/*-trigger-rst.pkt Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 11/13] selftest: packetdrill: Refine tcp_fastopen_server_reset-after-disconnect.pkt Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 12/13] selftest: packetdrill: Import sockopt-fastopen-key.pkt Kuniyuki Iwashima
2025-09-27 21:29 ` [PATCH v2 net-next 13/13] selftest: packetdrill: Import client-ack-dropped-then-recovery-ms-timestamps.pkt Kuniyuki Iwashima
2025-09-28 18:09 ` [PATCH v2 net-next 00/13] selftest: packetdrill: Import TFO server tests Willem de Bruijn
2025-09-30 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.2e545b6e6e601@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).