netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,  davem@davemloft.net
Cc: netdev@vger.kernel.org,  edumazet@google.com,  pabeni@redhat.com,
	 andrew+netdev@lunn.ch,  horms@kernel.org,  willemb@google.com,
	 petrm@nvidia.com,  dw@davidwei.uk,  shuah@kernel.org,
	 linux-kselftest@vger.kernel.org,
	 Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 0/5] selftests: hw-net: toeplitz: read config from the NIC directly
Date: Fri, 21 Nov 2025 18:10:02 -0500	[thread overview]
Message-ID: <willemdebruijn.kernel.2fe8d4c058a2d@gmail.com> (raw)
In-Reply-To: <20251121040259.3647749-1-kuba@kernel.org>

Jakub Kicinski wrote:
> First patch here tries to auto-disable building the iouring sample.
> Our CI will still run the iouring test(s), of course, but it looks
> like the liburing updates aren't very quick in distroes and having
> to hack around it when developing unrelated tests is a bit annoying.
> 
> Remaining 4 patches iron out running the Toeplitz hash test against
> real NICs. I tested mlx5, bnxt and fbnic, they all pass now.
> I switched to using YNL directly in the C code, can't see a reason
> to get the info in Python and pass it to C via argv. The old code
> likely did this because it predates YNL.
> 
> Jakub Kicinski (5):
>   selftests: hw-net: auto-disable building the iouring C code
>   selftests: hw-net: toeplitz: make sure NICs have pure Toeplitz
>     configured
>   selftests: hw-net: toeplitz: read the RSS key directly from C
>   selftests: hw-net: toeplitz: read indirection table from the device
>   selftests: hw-net: toeplitz: give the test up to 4 seconds
> 
>  .../testing/selftests/drivers/net/hw/Makefile | 23 ++++++-
>  .../selftests/drivers/net/hw/toeplitz.c       | 65 ++++++++++++++++++-
>  .../selftests/drivers/net/hw/toeplitz.py      | 28 ++++----
>  3 files changed, 98 insertions(+), 18 deletions(-)

For the series:

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks for improving the test! Especially addressing the missing
indirection table.

  parent reply	other threads:[~2025-11-21 23:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  4:02 [PATCH net-next 0/5] selftests: hw-net: toeplitz: read config from the NIC directly Jakub Kicinski
2025-11-21  4:02 ` [PATCH net-next 1/5] selftests: hw-net: auto-disable building the iouring C code Jakub Kicinski
2025-11-23  0:55   ` David Wei
2025-11-25  2:49     ` Jakub Kicinski
2025-11-21  4:02 ` [PATCH net-next 2/5] selftests: hw-net: toeplitz: make sure NICs have pure Toeplitz configured Jakub Kicinski
2025-11-21  4:02 ` [PATCH net-next 3/5] selftests: hw-net: toeplitz: read the RSS key directly from C Jakub Kicinski
2025-11-23  2:07   ` David Wei
2025-11-21  4:02 ` [PATCH net-next 4/5] selftests: hw-net: toeplitz: read indirection table from the device Jakub Kicinski
2025-11-21 23:12   ` Willem de Bruijn
2025-11-22  1:32     ` Jakub Kicinski
2025-11-22  2:16       ` Willem de Bruijn
2025-11-21  4:02 ` [PATCH net-next 5/5] selftests: hw-net: toeplitz: give the test up to 4 seconds Jakub Kicinski
2025-11-21 23:10 ` Willem de Bruijn [this message]
2025-11-25  3:10 ` [PATCH net-next 0/5] selftests: hw-net: toeplitz: read config from the NIC directly patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.2fe8d4c058a2d@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).