public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Akhilesh Samineni <akhilesh.samineni@broadcom.com>,
	 Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net,  edumazet@google.com,  kuba@kernel.org,
	 pabeni@redhat.com,  andrew+netdev@lunn.ch,  horms@kernel.org,
	 willemb@google.com,  daniel.zahka@gmail.com,
	 netdev@vger.kernel.org,  linux-kernel@vger.kernel.org,
	 jayakrishnan.udayavarma@broadcom.com,
	 ajit.khaparde@broadcom.com,  kiran.kella@broadcom.com,
	 sachin.suman@broadcom.com
Subject: Re: [net-next 1/3] psp: Support resetting statistics on a device
Date: Fri, 06 Mar 2026 15:37:22 -0500	[thread overview]
Message-ID: <willemdebruijn.kernel.316df6285de54@gmail.com> (raw)
In-Reply-To: <CANQF7iA6y7MDR6KfESUnDqFZLOBsgvkUqzAx_3GboF=c9TkDoQ@mail.gmail.com>

Akhilesh Samineni wrote:
> On Thu, Mar 5, 2026 at 7:55 PM Willem de Bruijn
> <willemdebruijn.kernel@gmail.com> wrote:
> >
> > Akhilesh Samineni wrote:
> > > On Tue, Mar 3, 2026 at 2:45 AM Willem de Bruijn
> > > <willemdebruijn.kernel@gmail.com> wrote:
> > > >
> > > > Akhilesh Samineni wrote:
> > > > > Drivers may need to reset per-device PSP statistics to zero.
> > > >
> > > > The series does not include rationale why this may be needed.
> > > >
> > > > What makes PSP counters special in this regard?
> > > >
> > >
> > > The PSP supports dynamic administrative states, allowing it to be
> > > enabled or disabled during runtime. Currently, statistics are
> > > persistent across these state transitions, which can lead to baseline
> > > drift and complicate telemetry analysis.
> >
> > How is this dynamic enable/disable configured, and can stats reset be
> > part of that, rather than a separate API?
> >
> 
> Instead of bundling the statistics reset with the transition to the
> disabled mode, we considered providing a separate reset operation to
> give users the flexibility to clear counters without toggling the PSP
> state.

Flexibility. And responsibility. A user process that waits on a
notification to exercise this API? That would be quite complex and
clunky.

If counter reset is expected on device disable, more robust to have
that part of the reset logic itself.


  reply	other threads:[~2026-03-06 20:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 19:53 [net-next 0/3] psp: Support PSP reset statistics Akhilesh Samineni
2026-03-02 19:53 ` [net-next 1/3] psp: Support resetting statistics on a device Akhilesh Samineni
2026-03-02 21:15   ` Willem de Bruijn
2026-03-05 10:54     ` Akhilesh Samineni
2026-03-05 14:25       ` Willem de Bruijn
2026-03-06 15:50         ` Akhilesh Samineni
2026-03-06 20:37           ` Willem de Bruijn [this message]
2026-03-05 14:59       ` Jakub Kicinski
2026-03-06 15:54         ` Akhilesh Samineni
2026-03-06 20:34           ` Jakub Kicinski
2026-03-02 19:53 ` [net-next 2/3] netdevsim: psp: Handle statistics reset Akhilesh Samineni
2026-03-02 19:53 ` [net-next 3/3] selftests: drv-net: psp: add reset statistics test Akhilesh Samineni
2026-03-02 23:05   ` Jakub Kicinski
2026-03-05 10:55     ` Akhilesh Samineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.316df6285de54@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=akhilesh.samineni@broadcom.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jayakrishnan.udayavarma@broadcom.com \
    --cc=kiran.kella@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sachin.suman@broadcom.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox