From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xin Zhao <jackzxcui1989@163.com>,
willemdebruijn.kernel@gmail.com, edumazet@google.com,
ferenc@fejes.dev
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Xin Zhao <jackzxcui1989@163.com>
Subject: Re: [PATCH net-next v10 1/2] net: af_packet: remove last_kactive_blk_num field
Date: Sun, 31 Aug 2025 21:18:08 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.320d357b92e75@gmail.com> (raw)
In-Reply-To: <20250831100822.1238795-2-jackzxcui1989@163.com>
Xin Zhao wrote:
> kactive_blk_num (K) is incremented on block close. last_kactive_blk_num (L)
> is set to match K on block open and each timer. So the only time that they
> differ is if a block is closed in tpacket_rcv and no new block could be
> opened.
> So the origin check L==K in timer callback only skip the case 'no new block
> to open'. If we remove L==K check, it will make prb_curr_blk_in_use check
> earlier, which will not cause any side effect.
>
> Signed-off-by: Xin Zhao <jackzxcui1989@163.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2025-09-01 1:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 10:08 [PATCH net-next v10 0/2] net: af_packet: optimize retire operation Xin Zhao
2025-08-31 10:08 ` [PATCH net-next v10 1/2] net: af_packet: remove last_kactive_blk_num field Xin Zhao
2025-09-01 1:18 ` Willem de Bruijn [this message]
2025-09-02 14:04 ` Jason Xing
2025-08-31 10:08 ` [PATCH net-next v10 2/2] net: af_packet: Use hrtimer to do the retire operation Xin Zhao
2025-09-01 1:21 ` Willem de Bruijn
2025-09-02 15:43 ` Jason Xing
2025-09-02 16:42 ` Jason Xing
-- strict thread matches above, loose matches on Subject: below --
2025-09-03 14:56 [PATCH net-next v10 1/2] net: af_packet: remove last_kactive_blk_num field Xin Zhao
2025-09-04 2:09 ` Jason Xing
2025-09-04 2:35 Xin Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.320d357b92e75@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ferenc@fejes.dev \
--cc=horms@kernel.org \
--cc=jackzxcui1989@163.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).