Netdev List
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
	 Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net,  netdev@vger.kernel.org,
	 edumazet@google.com,  pabeni@redhat.com,  andrew+netdev@lunn.ch,
	 horms@kernel.org
Subject: Re: [PATCH net-next 2/2] selftests: drv-net: so_txtime: check IP versions
Date: Mon, 08 Jun 2026 18:09:15 -0400	[thread overview]
Message-ID: <willemdebruijn.kernel.356106e98a673@gmail.com> (raw)
In-Reply-To: <20260608143913.349e45c4@kernel.org>

Jakub Kicinski wrote:
> On Mon, 08 Jun 2026 16:25:01 -0400 Willem de Bruijn wrote:
> > > diff --git a/tools/testing/selftests/drivers/net/so_txtime.py b/tools/testing/selftests/drivers/net/so_txtime.py
> > > index ddcd2c0e06a8..8fe061f52055 100755
> > > --- a/tools/testing/selftests/drivers/net/so_txtime.py
> > > +++ b/tools/testing/selftests/drivers/net/so_txtime.py
> > > @@ -64,6 +64,7 @@ from lib.py import NetDrvEpEnv, bkg, cmd, defer, tc
> > >  @ksft_variants(_test_variants_mono())
> > >  def test_so_txtime_mono(cfg, ipver, args_tx, args_rx):
> > >      """Run all variants of monotonic (fq) tests."""
> > > +    cfg.require_ipver(ipver)  
> > 
> > This may cause aconflict with my outstanding SO_TXTIME series.
> > And more importantly miss having it in the new test_so_txtime_fq_tai
> > variant.
> > 
> > Could this test be moved to test_so_txtime that all of them call?
> > 
> > (there is WIP to add another mono_hw variant too)
> 
> Ah, sorry, missed that. Would you be willing to take these patches
> and add it to your next series, then? Or the WIP stuff will take longer
> than say a week to surface?

That will take more than a week. But I can respin this regardless.
Apologies for the test breakage.

  reply	other threads:[~2026-06-08 22:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 17:33 [PATCH net-next 0/2] selftests: drv-net: so_txtime: trivial fixes Jakub Kicinski
2026-06-08 17:33 ` [PATCH net-next 1/2] selftests: drv-net: so_txtime: remember to deploy the binaries Jakub Kicinski
2026-06-08 20:21   ` Willem de Bruijn
2026-06-08 17:33 ` [PATCH net-next 2/2] selftests: drv-net: so_txtime: check IP versions Jakub Kicinski
2026-06-08 20:25   ` Willem de Bruijn
2026-06-08 21:39     ` Jakub Kicinski
2026-06-08 22:09       ` Willem de Bruijn [this message]
2026-06-08 20:21 ` [PATCH net-next 0/2] selftests: drv-net: so_txtime: trivial fixes Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.356106e98a673@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox