Re: [PATCH net-next v4 2/5] net: core: factor out the GSO device limit check

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

Wang Zhan wrote:
> gso_features_check() decides whether an egress device can offload a GSO
> skb as a single TSO frame by comparing the segment count and the frame
> length against the device limits.  The resegmentation path added by a
> later patch caps the MSS segments per output skb and needs the same
> features computed without those limits, so put the two tests in a helper
> and gate them with one flag.
> 
> __netif_skb_features() takes that flag and takes the place of
> netif_skb_features(), which becomes an inline wrapper in netdevice.h and
> passes the flag set.  Existing callers keep their call, and the
> resegmentation path asks for the features without the limit checks.
> 
> No functional changes.
> 
> Assisted-by: LLM
> Signed-off-by: Wang Zhan <wang.zhan@smartx.com>
> 
> ---
> v4:
> - keep the two limit tests as separate returns
> - move the wrapper into netdevice.h, export __netif_skb_features()
> v3: https://lore.kernel.org/20260928044102.1004310-3-wang.zhan@smartx.com/
> v2: https://lore.kernel.org/20260918084651.3022878-2-wang.zhan@smartx.com/
> v1: https://lore.kernel.org/20260917063854.2011613-2-wang.zhan@smartx.com/

Reviewed-by: Willem de Bruijn <willemb@google.com>