From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 128A52F0C52 for ; Mon, 22 Sep 2025 19:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758569916; cv=none; b=mJd1io/vMNueaCvJDcydkXULNs0EHZcFIAN8fFaxZqIqcdKDCPSznJetDKCesBqTtrCkCKmfDY2/N8KTQHL2pplxremC7dlh1gpAyOA1rYuzat9QOnCf3xtuXjqy3GuKFyo5/IQxe3onuWdip+UYF0Fk+eI0jxOwt88XdoWh6o8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758569916; c=relaxed/simple; bh=wPfLFlEhQ10lVPBK0QkKuPYsFDMT88ye1SoyoPyiZFs=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=IXEinob47KQhMqTLoChO2fu8r3X3XA4ZgXs8FKBORNdoNGJPvCtQjfKCCG9oQ9M8HmMm0yrzPxV7WOU1Pzrj+XQvVsi3jpv6hz1U3jM2l8jd/ZA5grdL8w8sMtf5iSYKnCsTI4oY57aONyCEHbIrkJZIVrz3jVo1BTCwQblKKsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VJdJ2Qz/; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VJdJ2Qz/" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4ca7a71adcbso11986201cf.3 for ; Mon, 22 Sep 2025 12:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758569914; x=1759174714; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6i3MlHtjGFbHj5X67wDWuS9zmOt/GF2t9nIF1CeTPP4=; b=VJdJ2Qz/oJWvFW1pHmRtpfx3YQSmb+DeQaOOFLhE5oOIqMlAElbKMEcsppK8NhFtRL 1C/5VEIHu0iXWbSuWmLRaAdIoVD9GO2Ws8nfFQ1uvu8IknC5KvidmqbSjIQEbqVfTVSB 2QUxfmLG5NoAeomnRN/df11WpcGAAQ+ftgoCDsHJ0zDfvTRxJO2tgTBHCHc6QeLKqy44 MGmbDVYH8Opd7XpHCWMIuA8V9+Qd+s7ygiwT2JudSgmIDyXao5c3htn8kUGAkj+B6CKb 8C5+jjjk2Lh0vR37PpCkCpA8DCHVL3fMXulhatSIt82S5kAF5kVT421/i/MCoHam2p4W LV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758569914; x=1759174714; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6i3MlHtjGFbHj5X67wDWuS9zmOt/GF2t9nIF1CeTPP4=; b=FkQNhI/75s77vcZA/uGuxEuqwrn35s5DcxZvhemWdrbYqN8347Du6ngPXovyzs6CA3 ptaaQ+y3K0vd+oypBvTrWV0jH9vO2Rg0QXZjjIycIblh5e61Iz31f4HQ0Y5tkilnzauR nz2/rlKPBly60aVjuQ/YQcogOH7lzlKZ6ZuGKk0CPcHJzRQsvxvqZ8owC6bCrd4BbLE2 yj3amM0kA36ndbwJdDTfu8cujLZbDzXlV6UVJ8R2BEawDOBdPyDw2IIuQwdZCRmhifdg ckwswMSWQ1cOhLC5WWFcqmwy+NHVn43xLMXLd0hB9QvNGdt+VpDqeWtYr25p19BXOzpl 8/ng== X-Forwarded-Encrypted: i=1; AJvYcCXA9mnLhO1eoR43ls23/m1kC1It1sZaZtllYnDmLeHcEOsGSI+Qx+Mh975rch6GzuXiAQ3dgwQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwNTjLiq+5Cm9vOfZSQDJdSWeuOJQXnROLDhJiSTc9vzg1PBTHo 3Cz6OJNZEQLkbMI8ioFtyowQioGxYGmeHabPVa5xRlf6aqwoEuFrOf97 X-Gm-Gg: ASbGncs/S51R1FGMUh6qTIqY6un1fwq0Rjx58+TmKHTzO1wNC95r+qGmmL43MJT2kj2 OjxxF+6mz3VcAuHxjIH4L+PfBdbaFNBC86DDvzBHtSQn9MCB2qGFvRmBHh2INHglgjc9Hpzn2Lx j2oZwZttLAEYGDTwvBgYyPKGG3u0NwPC0raqjTuo2Ro1DjNxYH0ms3FNS7KKVA4eR09M5dieWE3 5v2ZyaRswcbWV37geHFJkmuZqIM8syRFX+oNIiAnHZQlzavmOcPTygViIJngotdhzZLcSpIkEvb PIl+gY8TjfJ9vE9Izbp2G0md6Hz+GSoyGWU7SyY4juZRn5vemeCOCntpB6Y4y4xXQsPZFfsGSYb 0HPSzs6bu1ScLI21XN9yYsWXvn/ZYrbwDWvcW8mUuGE92qmV3HruD5JyUy7moCWRtuDPnBt3MiI fdPkm0 X-Google-Smtp-Source: AGHT+IGkHzNu6t/SPPqhpgqdaAin/hhAR5YuJRs8iLlNADeM14QiI5l3rfJ5t1agknOPG+GAcsQ09g== X-Received: by 2002:a05:622a:1e0c:b0:4b5:e21c:80ba with SMTP id d75a77b69052e-4c072b441e3mr145527431cf.69.1758569913776; Mon, 22 Sep 2025 12:38:33 -0700 (PDT) Received: from gmail.com (21.33.48.34.bc.googleusercontent.com. [34.48.33.21]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-8494af03273sm256045285a.70.2025.09.22.12.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 12:38:33 -0700 (PDT) Date: Mon, 22 Sep 2025 15:38:32 -0400 From: Willem de Bruijn To: Richard Gobert , netdev@vger.kernel.org, pabeni@redhat.com, ecree.xilinx@gmail.com, willemdebruijn.kernel@gmail.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org, corbet@lwn.net, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, leon@kernel.org, dsahern@kernel.org, ncardwell@google.com, kuniyu@google.com, shuah@kernel.org, sdf@fomichev.me, aleksander.lobakin@intel.com, florian.fainelli@broadcom.com, alexander.duyck@gmail.com, linux-kernel@vger.kernel.org, linux-net-drivers@amd.com, Richard Gobert Message-ID: In-Reply-To: <20250922084103.4764-4-richardbgobert@gmail.com> References: <20250922084103.4764-1-richardbgobert@gmail.com> <20250922084103.4764-4-richardbgobert@gmail.com> Subject: Re: [PATCH net-next v7 3/5] net: gso: restore ids of outer ip headers correctly Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Richard Gobert wrote: > Currently, NETIF_F_TSO_MANGLEID indicates that the inner-most ID can > be mangled. Outer IDs can always be mangled. > > Make GSO preserve outer IDs by default, with NETIF_F_TSO_MANGLEID allowing > both inner and outer IDs to be mangled. > > This commit also modifies a few drivers that use SKB_GSO_FIXEDID directly. > > Signed-off-by: Richard Gobert > Reviewed-by: Edward Cree # for sfc Accidentally wrote feedback in v6 instead of v7. Both question and point still apply.