From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Soichiro Ueda <the.latticeheart@gmail.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Soichiro Ueda <the.latticeheart@gmail.com>,
Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Miao Wang <shankerwangmiao@gmail.com>
Subject: Re: [PATCH net-next v2] selftests: af_unix: validate SO_PEEK_OFF advancement and reset
Date: Thu, 05 Mar 2026 09:30:50 -0500 [thread overview]
Message-ID: <willemdebruijn.kernel.38f5ed88e59df@gmail.com> (raw)
In-Reply-To: <20260305070525.184945-1-the.latticeheart@gmail.com>
Soichiro Ueda wrote:
> Extend the so_peek_off selftest to ensure the socket peek offset is handled
> correctly after both MSG_PEEK and actual data consumption.
>
> Verify that the peek offset advances by the same amount as the number of
> bytes read when performing a read with MSG_PEEK.
>
> After exercising SO_PEEK_OFF via MSG_PEEK, drain the receive queue with a
> non-peek recv() and verify that it can receive all the content in the
> buffer and SO_PEEK_OFF returns back to 0.
>
> The verification after actual data consumption was suggested by Miao Wang
> when the original so_peek_off selftest was introduced.
>
> Link: https://lore.kernel.org/all/7B657CC7-B5CA-46D2-8A4B-8AB5FB83C6DA@gmail.com/
> Suggested-by: Miao Wang <shankerwangmiao@gmail.com>
> Signed-off-by: Soichiro Ueda <the.latticeheart@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2026-03-05 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 7:05 [PATCH net-next v2] selftests: af_unix: validate SO_PEEK_OFF advancement and reset Soichiro Ueda
2026-03-05 14:30 ` Willem de Bruijn [this message]
2026-03-06 5:26 ` Kuniyuki Iwashima
2026-03-06 17:01 ` Soichiro Ueda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.38f5ed88e59df@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=shankerwangmiao@gmail.com \
--cc=the.latticeheart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox