From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC7253D1A83 for ; Fri, 22 May 2026 13:44:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779457467; cv=none; b=pSXGkBxIFvxZnz1t9tHBbPoO9S/lntDj6PdtXDnLKwJWjGRMG1L2YcxOFvf7zRmNMjLtD+N65oBH2d/Dw5w9h6XWvCYlmRJkG1WHHESlubzETmRkwL+YLLwCPo1A804d+0Bd+xQtgGYxqg1enEb3maX4f5rtpUUyvzMMQlqGn30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779457467; c=relaxed/simple; bh=5la0D/R7CJ4PfmB6OsvL8OiyVTJizo/jhlIOOzkCkEY=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=IRwy0d4hrPkc1s7+PRBdrj1+gp2IagQ2MkRGRi+bHC3McFg242UJJAzJ5ytyi0O+Ibegx9lO7ctgV1AedNaKfnO+2jJKa3GQnnSJ7EDYdaSVDGBaitYI+qpDHUem0yacmfKTp0xK+F4ADBFvgBZ/hMhImbiJmGd/kOsd2Cz2Wt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fTVqZKX6; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fTVqZKX6" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-7bd9f61458eso54881627b3.0 for ; Fri, 22 May 2026 06:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779457457; x=1780062257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1nuM9CpdZSF4/7l72HqNTMm6D+ZaatVl7iUT+72HqVk=; b=fTVqZKX6cGQ95OYWvmMRir96F0BGBHvwmQPKD7PFC30MdYJziLi+5+F/93w444J7o6 Bo0xik+GDGaYfWmAjaNvExZCyJvqN+MW6lTg6HFq3uPyfUk2ZgbxDp9xFoREzDUzrzZi Tq3yBUKHS57pe/8JXyYyQsF2Tt8EUXbLXlMt03SH/joXu0jM+tT3Tm5wu5sa2iOsmlNo 2RLpH5fWsvlxpn5BzFG1MtoHISh+4HcvEN6cXeOI+GrG5/Uvucj3ENpu6VvjmwjWm2xk bhS7K6UAGvNYR1BX6R8MTl6x9NKeALGgs/RHj3LqBTUKyT2ty52DI6HMpzxN9cyuyjgZ /3fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779457457; x=1780062257; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1nuM9CpdZSF4/7l72HqNTMm6D+ZaatVl7iUT+72HqVk=; b=YkkSF9Egn5kkFLKQ7mlMMcpdMVsOs9AFQUepYCgSeexArSiC4Ug+tbNlSClah0JjUU pnlRgEq3+wAK4WbcNzdffqvlPXzPQFQTqJtvVtRrIfO752R5DN1OfJLQqM/Ry6d9aBIp g6RQWJWdIeR7D2vsPZDM1Wk/2Kz4I0ZiK1NicX9vTM88H1nO4wjnzmN8YQ+IJqlxld2/ tH7rlgWPtAggidox8xuF89XT+MYkM8nQGR3J/mkiuWIqznflT1/VS9Gp5ude93VTKgyE tXTLMeU636vxVKh3tQlulIBBGBTIEPmNx1F+g/l9hI/I2dadjCMzfwRx64jZR1ukHVqO 8R5w== X-Forwarded-Encrypted: i=1; AFNElJ/jCHf41r1wg31mkKwH4eLJ7sWZ+HLODnwgCq0QIdmWwK5wc7uJpC8X3+B3XtjuSzjUt7Lveq8=@vger.kernel.org X-Gm-Message-State: AOJu0YyY7FkJq2v1pd+VpPKF71PluijrBiQTaXMCW9TQRFcFnL86l0Hn U/f4ZKX311rSKr3EkL0sB7TlgrpfnpkQu7eL0/iMxMsdSk13sTT6FiFz X-Gm-Gg: Acq92OHdOFT7LcoEPKRvN5vxuvG3Udy/fpZxtuEc27hfAi6XO/g5q9EPg9p4Dvf9JX2 i/3Nkn1zRQTHG+lmNtS7/JXA5t/4PHJebcg0MEz4lxpHo55BBptUI+BxFsewj5cnSjl/sPANf38 hRN4zRuKTY9UBui+F3hP35TlR3gKVWNSBPNNDii+MQg0KzbcV0IImoI7Cb40iuWH1hTYLwdZJCG +71FBDKr/aDqREdSjIPZi3/mu5JG9kNm7P8/GKFc5atn7B/XS4RKHIgnNorkrxxUKs0rYHgIngc wDyFGXE5RRXLmHZKHW8CdOWaFDGmumTRLmKMzcQRAQ7+GDoGZ4wtibvt+qIAUWMAxLq2FN5OXLM iQf7dtwVapR6cJW8dToo50MCgy2QOvjDBLgiE7BIh29N00JsuM/iYw9iDsHxXq1xYWDPTFBTrib /E8GmwaXlwO4S7auBKBMHb38n8U55CqxSSRIyfMjfjSIaFxmF5pw0AMQLVzVpLhDwwVaF7AzeQt 7hKvvuQsrDKf80qwg== X-Received: by 2002:a05:690c:d0f:b0:7bd:9899:f904 with SMTP id 00721157ae682-7d3368b4ec8mr41250927b3.39.1779457456882; Fri, 22 May 2026 06:44:16 -0700 (PDT) Received: from gmail.com (141.139.145.34.bc.googleusercontent.com. [34.145.139.141]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7d389819068sm8218937b3.3.2026.05.22.06.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 06:44:16 -0700 (PDT) Date: Fri, 22 May 2026 09:44:16 -0400 From: Willem de Bruijn To: Weiming Shi , netdev@vger.kernel.org Cc: willemdebruijn.kernel@gmail.com, jasowang@redhat.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, dongli.zhang@oracle.com, xmei5@asu.edu, linux-kernel@vger.kernel.org, Weiming Shi Message-ID: In-Reply-To: <20260521163230.1478627-2-bestswngs@gmail.com> References: <20260521163230.1478627-2-bestswngs@gmail.com> Subject: Re: [PATCH net] tap: free page on error paths in tap_get_user_xdp() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Weiming Shi wrote: > tap_get_user_xdp() rejects a frame shorter than ETH_HLEN with -EINVAL, > and returns -ENOMEM when build_skb() fails. Both paths jump to the err > label without freeing the page that vhost_net_build_xdp() allocated for > the frame. tap_sendmsg() discards the per-buffer return value and always > returns 0, so vhost_tx_batch() takes the success path and never frees > the page; each rejected frame in a batch leaks one page-frag chunk. > > Free the page on both error paths, before the skb is built. This is the > tap counterpart of the same leak in tun_xdp_one(). > > Fixes: 0efac27791ee ("tap: accept an array of XDP buffs through sendmsg()") > Fixes: ed7f2afdd0e0 ("tap: add missing verification for short frame") > Reported-by: Xiang Mei > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Weiming Shi Reviewed-by: Willem de Bruijn