From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Gobert <richardbgobert@gmail.com>,
netdev@vger.kernel.org, pabeni@redhat.com,
ecree.xilinx@gmail.com, willemdebruijn.kernel@gmail.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, corbet@lwn.net, saeedm@nvidia.com,
tariqt@nvidia.com, mbloch@nvidia.com, leon@kernel.org,
dsahern@kernel.org, ncardwell@google.com, kuniyu@google.com,
shuah@kernel.org, sdf@fomichev.me,
aleksander.lobakin@intel.com, florian.fainelli@broadcom.com,
alexander.duyck@gmail.com, linux-kernel@vger.kernel.org,
linux-net-drivers@amd.com,
Richard Gobert <richardbgobert@gmail.com>
Subject: Re: [PATCH net-next v7 2/5] net: gro: only merge packets with incrementing or fixed outer ids
Date: Mon, 22 Sep 2025 15:38:42 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.416ce098eb01@gmail.com> (raw)
In-Reply-To: <20250922084103.4764-3-richardbgobert@gmail.com>
Richard Gobert wrote:
> Only merge encapsulated packets if their outer IDs are either
> incrementing or fixed, just like for inner IDs and IDs of non-encapsulated
> packets.
>
> Add another ip_fixedid bit for a total of two bits: one for outer IDs (and
> for unencapsulated packets) and one for inner IDs.
>
> This commit preserves the current behavior of GSO where only the IDs of the
> inner-most headers are restored correctly.
>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2025-09-22 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 8:40 [PATCH net-next v7 0/5] net: gso: restore outer ip ids correctly Richard Gobert
2025-09-22 8:40 ` [PATCH net-next v7 1/5] net: gro: remove is_ipv6 from napi_gro_cb Richard Gobert
2025-09-22 8:41 ` [PATCH net-next v7 2/5] net: gro: only merge packets with incrementing or fixed outer ids Richard Gobert
2025-09-22 19:38 ` Willem de Bruijn [this message]
2025-09-22 8:41 ` [PATCH net-next v7 3/5] net: gso: restore ids of outer ip headers correctly Richard Gobert
2025-09-22 19:38 ` Willem de Bruijn
2025-09-22 8:41 ` [PATCH net-next v7 4/5] net: gro: remove unnecessary df checks Richard Gobert
2025-09-22 19:40 ` Willem de Bruijn
2025-09-22 8:41 ` [PATCH net-next v7 5/5] selftests/net: test ipip packets in gro.sh Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.416ce098eb01@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=mbloch@nvidia.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).