From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next] selftests/net: packetdrill: add CONFIG_MAX_SKB_FRAGS=17
Date: Tue, 24 Mar 2026 10:53:37 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.94dd9c2ea7d@gmail.com> (raw)
In-Reply-To: <20260324142556.1844523-1-edumazet@google.com>
Eric Dumazet wrote:
> Before adding tests about RWIN, enforce the default linux value
> for the number of fragments per skb.
>
> With 17 fragments, sizeof(skb_shared_info) == 320.
>
> With 45 fragments, sizeof(skb_shared_info) == 768.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> tools/testing/selftests/net/packetdrill/config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/net/packetdrill/config b/tools/testing/selftests/net/packetdrill/config
> index c4a19a78552111df690d2c97c0f3a8abe2176ada..8c739db4752c3abaaa8862ea2aeb661a2d5f0575 100644
> --- a/tools/testing/selftests/net/packetdrill/config
> +++ b/tools/testing/selftests/net/packetdrill/config
> @@ -1,6 +1,7 @@
> CONFIG_HZ=1000
> CONFIG_HZ_1000=y
> CONFIG_IPV6=y
> +CONFIG_MAX_SKB_FRAGS=17
> CONFIG_NET_NS=y
> CONFIG_NET_SCH_FIFO=y
> CONFIG_NET_SCH_FQ=y
Why do we need to make this explicit, if it is the default?
prev parent reply other threads:[~2026-03-24 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 14:25 [PATCH net-next] selftests/net: packetdrill: add CONFIG_MAX_SKB_FRAGS=17 Eric Dumazet
2026-03-24 14:53 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.94dd9c2ea7d@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox