RE: [PATCH net-next 1/1] selftests/net: Add packetdrill packetdrill cases

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

Chia-Yu Chang (Nokia) wrote:
> > -----Original Message-----
> > From: Neal Cardwell <ncardwell@google.com> 
> > Sent: Thursday, January 8, 2026 11:47 PM
> > To: Chia-Yu Chang (Nokia) <chia-yu.chang@nokia-bell-labs.com>
> > Cc: pabeni@redhat.com; edumazet@google.com; parav@nvidia.com; linux-doc@vger.kernel.org; corbet@lwn.net; horms@kernel.org; dsahern@kernel.org; kuniyu@google.com; bpf@vger.kernel.org; netdev@vger.kernel.org; dave.taht@gmail.com; jhs@mojatatu.com; kuba@kernel.org; stephen@networkplumber.org; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; andrew+netdev@lunn.ch; donald.hunter@gmail.com; ast@fiberby.net; liuhangbin@gmail.com; shuah@kernel.org; linux-kselftest@vger.kernel.org; ij@kernel.org; Koen De Schepper (Nokia) <koen.de_schepper@nokia-bell-labs.com>; g.white@cablelabs.com; ingemar.s.johansson@ericsson.com; mirja.kuehlewind@ericsson.com; cheshire <cheshire@apple.com>; rs.ietf@gmx.at; Jason_Livingood@comcast.com; Vidhi Goel <vidhi_goel@apple.com>; Willem de Bruijn <willemb@google.com>
> > Subject: Re: [PATCH net-next 1/1] selftests/net: Add packetdrill packetdrill cases
> > 
> > 
> > CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> > 
> > 
> > 
> > On Thu, Jan 8, 2026 at 10:58 AM <chia-yu.chang@nokia-bell-labs.com> wrote:
> > >
> > > From: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
> > >
> > > Linux Accurate ECN test sets using ACE counters and AccECN options to 
> > > cover several scenarios: Connection teardown, different ACK 
> > > conditions, counter wrapping, SACK space grabbing, fallback schemes, 
> > > negotiation retransmission/reorder/loss, AccECN option drop/loss, 
> > > different handshake reflectors, data with marking, and different sysctl values.
> > >
> > > Co-developed-by: Ilpo Järvinen <ij@kernel.org>
> > > Signed-off-by: Ilpo Järvinen <ij@kernel.org>
> > > Co-developed-by: Neal Cardwell <ncardwell@google.com>
> > > Signed-off-by: Neal Cardwell <ncardwell@google.com>
> > > ---
> > 
> > Chia-Yu, thank you for posting the packetdrill tests.
> > 
> > A couple thoughts:
> > 
> > (1) These tests are using the experimental AccECN packetdrill support that is not in mainline packetdrill yet. Can you please share the github URL for the version of packetdrill you used? I will work on merging the appropriate experimental AccECN packetdrill support into the Google packetdrill mainline branch.
> > 
> > (2) The last I heard, the tools/testing/selftests/net/packetdrill/
> > infrastructure does not run tests in subdirectories of that packetdrill/ directory, and that is why all the tests in tools/testing/selftests/net/packetdrill/ are in a single directory.
> > When you run these tests, do all the tests actually get run? Just wanted to check this. :-)
> > 
> > Thanks!
> > neal
> 
> Hi Neal,
> 
> Regards (2), I will put all ACCECN cases in the tools/testing/selftests/net/packetdrill/
> But I would like to include another script to avoid running these AccECN tests one-by-one manually, does it make sense to you?
> Thanks.

All scripts under tools/testing/selftests/net/packetdrill are already
picked up for automated testing in kselftests:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=8a405552fd3b