From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Chintan Vankar <c-vankar@ti.com>,
Danish Anwar <danishanwar@ti.com>, Daolin Qiu <d-qiu@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Felix Maurer <fmaurer@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Neelima Muralidharan <neelima@ti.com>,
Paolo Abeni <pabeni@redhat.com>,
Praneeth Bajjuri <praneeth@ti.com>,
Pratheesh Gangadhar TK <pratheesh@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Simon Horman <horms@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH RFC net-next v3] hsr: Allow to send a specific port and with HSR header
Date: Wed, 06 May 2026 09:20:41 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.b7832f991167@gmail.com> (raw)
In-Reply-To: <20260506070928.hr8uavhJ@linutronix.de>
Sebastian Andrzej Siewior wrote:
> On 2026-05-05 12:14:58 [-0400], Willem de Bruijn wrote:
> > > But I can't expect that the header is always there. A random ping/ arp
> > > packet goes via the same flow. At the same time I don't want to make it
> > > mandatory for all AF_PACKET users by checking the skb's socket.
> >
> > I thought skb->protocol is the unambiguous signal whether this custom
> > header is present?
>
> No, I parse the header. As far as I can tell this set based on the
> header bits from data passed to af_packet. Even if I could change this
> to something else, these 16bit should better not collide with anything
> else so I think used the eth-type and expecting nobody sending a PTP
> packet is good.
Is that more fragile than a specific protocol? And introduces that
dependency on mirroring the Ethernet format. But your call.
Ethernet does have requirements on MAC address format, so a layout
that corresponds to an invalid address could be a signal.
next prev parent reply other threads:[~2026-05-06 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 14:01 [PATCH RFC net-next v3] hsr: Allow to send a specific port and with HSR header Sebastian Andrzej Siewior
2026-04-29 17:46 ` Willem de Bruijn
2026-05-04 8:59 ` Sebastian Andrzej Siewior
2026-05-04 17:08 ` Willem de Bruijn
2026-05-05 9:52 ` Sebastian Andrzej Siewior
2026-05-05 16:14 ` Willem de Bruijn
2026-05-06 7:09 ` Sebastian Andrzej Siewior
2026-05-06 13:20 ` Willem de Bruijn [this message]
2026-05-07 15:43 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.b7832f991167@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=c-vankar@ti.com \
--cc=d-qiu@ti.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=neelima@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox