From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Gal Pressman <gal@nvidia.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Petr Machata <petrm@nvidia.com>, Coco Li <lixiaoyan@google.com>,
linux-kselftest@vger.kernel.org, Nimrod Oren <noren@nvidia.com>
Subject: Re: [PATCH net-next 2/2] selftests: drv-net: fix RPS mask handling for high CPU numbers
Date: Mon, 12 Jan 2026 11:06:12 -0500 [thread overview]
Message-ID: <willemdebruijn.kernel.e77552f797c0@gmail.com> (raw)
In-Reply-To: <a95dca83-b996-49e7-86d5-f07e8f178767@nvidia.com>
Gal Pressman wrote:
> On 12/01/2026 5:29, Willem de Bruijn wrote:
> > Gal Pressman wrote:
> >> The RPS bitmask bounds check uses ~(RPS_MAX_CPUS - 1) which equals ~15 =
> >> 0xfff0, only allowing CPUs 0-3.
> >>
> >> Change the mask to ~((1UL << RPS_MAX_CPUS) - 1) = ~0xffff to allow CPUs
> >> 0-15.
> >>
> >> Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
> >> Reviewed-by: Nimrod Oren <noren@nvidia.com>
> >> Signed-off-by: Gal Pressman <gal@nvidia.com>
> >
> > Should go to net instead of net-next?
> >
> > Reviewed-by: Willem de Bruijn <willemb@google.com>
>
> I usually send tests bug fixes to net-next, since it doesn't fix a bug
> in the kernel.
>
> Should I send those to net instead?
I'm not aware of a separate policy for tests. Not sure if maintainers
have a preference. Probably behavior on this is a bit inconsistent
anyway.
prev parent reply other threads:[~2026-01-12 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 17:16 [PATCH net-next 0/2] selftests: Couple of fixes in Toeplitz RPS cases Gal Pressman
2026-01-11 17:16 ` [PATCH net-next 1/2] selftests: drv-net: fix RPS mask handling in toeplitz test Gal Pressman
2026-01-12 3:43 ` Willem de Bruijn
2026-01-12 7:58 ` Gal Pressman
2026-01-11 17:16 ` [PATCH net-next 2/2] selftests: drv-net: fix RPS mask handling for high CPU numbers Gal Pressman
2026-01-12 3:29 ` Willem de Bruijn
2026-01-12 6:51 ` Gal Pressman
2026-01-12 16:06 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.e77552f797c0@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox