* Re: fix:rtl8xxxu_core: mark symbols static where possible [not found] <20160903102822.84E496201B@smtp.codeaurora.org> @ 2016-09-03 12:31 ` Jes Sorensen 0 siblings, 0 replies; 2+ messages in thread From: Jes Sorensen @ 2016-09-03 12:31 UTC (permalink / raw) To: Kalle Valo Cc: Baoyou Xie, linux-wireless, netdev, linux-kernel, arnd, xie.baoyou Kalle Valo <kvalo@codeaurora.org> writes: > Baoyou Xie <baoyou.xie@linaro.org> wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' >> [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is declared >> and don't need a declaration, but can be made static. >> so this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > > The title should be "rtl8xxxu: ". See: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name > > Also I assume Jes will take this. Yes to both accounts! Thanks, Jes ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] fix:rtl8xxxu_core: mark symbols static where possible @ 2016-08-27 16:14 Baoyou Xie 2016-09-03 10:28 ` Kalle Valo 0 siblings, 1 reply; 2+ messages in thread From: Baoyou Xie @ 2016-08-27 16:14 UTC (permalink / raw) To: Jes.Sorensen, kvalo Cc: linux-wireless, netdev, linux-kernel, arnd, baoyou.xie, xie.baoyou We get 1 warning about global functions without a declaration in the rtl8xxxu rtl8xxxu_core.c when building with W=1: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks it 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 77048db..95b54b8 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -894,7 +894,7 @@ int rtl8xxxu_write_rfreg(struct rtl8xxxu_priv *priv, return retval; } -int +static int rtl8xxxu_gen1_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c, int len) { struct device *dev = &priv->udev->dev; -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: fix:rtl8xxxu_core: mark symbols static where possible 2016-08-27 16:14 [PATCH] " Baoyou Xie @ 2016-09-03 10:28 ` Kalle Valo 0 siblings, 0 replies; 2+ messages in thread From: Kalle Valo @ 2016-09-03 10:28 UTC (permalink / raw) To: Baoyou Xie Cc: Jes.Sorensen, linux-wireless, netdev, linux-kernel, arnd, baoyou.xie, xie.baoyou Baoyou Xie <baoyou.xie@linaro.org> wrote: > We get 1 warning about global functions without a declaration > in the rtl8xxxu rtl8xxxu_core.c when building with W=1: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> The title should be "rtl8xxxu: ". See: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name Also I assume Jes will take this. -- Sent by pwcli https://patchwork.kernel.org/patch/9302457/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-03 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160903102822.84E496201B@smtp.codeaurora.org>
2016-09-03 12:31 ` fix:rtl8xxxu_core: mark symbols static where possible Jes Sorensen
2016-08-27 16:14 [PATCH] " Baoyou Xie
2016-09-03 10:28 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).