netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: John Heenan <john-AMlJbUfTsso@public.gmane.org>,
	Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower
Date: Fri, 04 Nov 2016 09:56:00 -0400	[thread overview]
Message-ID: <wrfjshr7mjrj.fsf@redhat.com> (raw)
In-Reply-To: <1478162497.1924.16.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> (Joe Perches's message of "Thu, 03 Nov 2016 01:41:37 -0700")

Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> writes:
> On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote:
>> Code is 80 characters wide, and comments are /* */ never the ugly C++
>> crap.
>
> You might look at the recent Linus Torvalds authored commit
> 5e467652ffef (?printk: re-organize log_output() to be more legible")
> which does both of those: c99 // comments and > 80 columns.
>
> Absolutes are for zealots.

What Linus does in his code, is totally up to him. What I pull into the
driver that *I* maintain, is up to me. It is perfectly normal to expect
submitters to respect the coding style of the piece of code they are
trying to edit.

Jes

  parent reply	other threads:[~2016-11-04 13:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1477769750.git.john@zgus.com>
2016-10-30 10:20 ` [PATCH 1/2] rtl8xxxu: Fix for authentication failure John Heenan
2016-11-03  1:00   ` Larry Finger
     [not found]     ` <8dba6346-332e-84e6-89b2-02033a449f25-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2016-11-03  7:10       ` John Heenan
2016-11-03 15:39         ` Larry Finger
2016-10-30 10:21 ` [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower John Heenan
2016-10-30 12:00   ` Jes Sorensen
2016-10-30 13:56     ` John Heenan
2016-10-30 23:02       ` Jes Sorensen
2016-11-03  8:41         ` Joe Perches
2016-11-03 15:43           ` Larry Finger
     [not found]           ` <1478162497.1924.16.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-11-04 13:56             ` Jes Sorensen [this message]
2016-11-03  1:00   ` Larry Finger
2016-11-03  2:58     ` David Miller
     [not found] <CANf5e8aQ+HZz47M3-4+qjsG=ZCaXhBFU_jVupLqT4rEYT2LQFQ@mail.gmail.com>
2016-11-08 14:29 ` Jes Sorensen
     [not found]   ` <wrfjh97i11vw.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-10 22:45     ` Barry Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjshr7mjrj.fsf@redhat.com \
    --to=jes.sorensen-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
    --cc=john-AMlJbUfTsso@public.gmane.org \
    --cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).