From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Arnd Bergmann'" <arnd@arndb.de>,
Kalle Valo <kvalo@codeaurora.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: use s8 instead of char
Date: Thu, 16 Jun 2016 12:07:31 -0400 [thread overview]
Message-ID: <wrfjvb19qfr0.fsf@redhat.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D5F4DA915@AcuExch.aculab.com> (David Laight's message of "Thu, 16 Jun 2016 16:02:38 +0000")
David Laight <David.Laight@ACULAB.COM> writes:
> From: Arnd Bergmann
>> On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote:
>> >
>> > Arnd,
>> >
>> > rtlwifi and rtl8xxxu are two distinct drivers managed by different
>> > people. I'd be really nice if you could split this into a per driver
>> > patch.
>> >
>> > That said, the use of char in rtl8xxxu is all as a flag indicator, so I
>> > don't think the s/char/s8/ conversion is justified. I used char rather
>> > than ugly bool to reduce the size of the struct.
>>
>> Makes sense, I'll resend without that change. If anything, the flag
>> should become u8, not s8 anyway.
>
> Does bool:8 work ?
Maybe, but bool is such an ugly datatype, so I'd rather use the other
ones.
Jes
prev parent reply other threads:[~2016-06-16 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 21:03 [PATCH] rtlwifi: use s8 instead of char Arnd Bergmann
2016-06-15 21:10 ` Jes Sorensen
2016-06-15 21:25 ` Arnd Bergmann
2016-06-16 16:02 ` David Laight
2016-06-16 16:07 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjvb19qfr0.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=chaoming_li@realsil.com.cn \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).