From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5FA4215F4A for ; Thu, 23 Oct 2025 15:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761234351; cv=none; b=Yd8Ydn2qUrixcaAgQT0AKfuYDSNWcO7CdCZAOsww19Kzdt011jWAWtF1s/Fe8c7jBb0sRQMvntswCfeV9f2QyoEb3uLphp1mF4vYDgsOigWLQNk4zbgf/W+xmosf8lTfRK0MSoBKc0Qux8mNkFA5/aLFF6jG2cRgkfjU4KnaZnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761234351; c=relaxed/simple; bh=WpbcaF8x2sasj+ApAXCwoMuJpqNIfGogMerrRKXqC4s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=iILNNheYUXNLkVwTnSuOOcO7hb5XpMgtxwWVz4wEPiMh9d0/pcbVwL3TkKuv71yswdfl6UeqNen4ih/h2v6YCjDSYSG0dm66eXVa2DV1i3MhaAnXMpTUNFekZqVjROMdRZcOLy4dqvrEbJ/YUIUKZYFmilY1BtH4JO0oPrzwzlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AHt9Y1bs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AHt9Y1bs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761234348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=50SfSxS4nKgs8hxb+bOC3hzEIaH0AgAoPcaR+jSb2yk=; b=AHt9Y1bsAZ5c0/qZoedyqKOo0DoBE4zTee8ejE1lgXmgnpGkBNZY7g4s/udqkWqvyNIdFZ AI8KXslUN3IokH1Sf3wmM/kBTE76nYPreYRi6DcwSYHKMq6upc6/5QU9ZioWs5i3YegGT6 IXLvtAY9qn66fWYPVPXDsyxVKtZ5DEg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-Nulw1dZHPnqiy-SGYN9AXw-1; Thu, 23 Oct 2025 11:45:45 -0400 X-MC-Unique: Nulw1dZHPnqiy-SGYN9AXw-1 X-Mimecast-MFC-AGG-ID: Nulw1dZHPnqiy-SGYN9AXw_1761234344 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-471125c8bc1so13218975e9.3 for ; Thu, 23 Oct 2025 08:45:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234343; x=1761839143; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=50SfSxS4nKgs8hxb+bOC3hzEIaH0AgAoPcaR+jSb2yk=; b=dZVZR70djewisyWb8nLmZZGccS8yI2AzkSpM/Kq2P4Fbr8L2KRn//1EhRblbcUL3/S UBZpmmZVYfNoee43C0N+5CrcLHRuejbqsSYdV21D8PQU+RFJ451ivRLf/uyVeO1dZi9N r+hNf2VKIeXzKkbCRMsLqUIvqBZTbvPUV4+Ssua/69e8fNXghD/8se8eMWsj6glOWOm/ s5DSGoUTn2nvFyh1KoxktG0hOD4JFe5Ax59oc+NGmsobynzM4kuqKQ8NHRHN89mw6nJf A4b3B+wI2mF6N1JzFxoojL/PSTGfqaihMXYZSJfi4ELCh15t4PxeI1Zz7UEgNG6Qrai8 UfMg== X-Forwarded-Encrypted: i=1; AJvYcCXOpIbl9QkpbBi3WqdywE8yEj8NjGBfPh+cOyQK2uUJgrCODJoQyRMaI6FTg32T0Xhh0ZoAg6g=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd1i5rMEV2sMwpl6MYKZL4kXGvcQVR5xjM0/D0xgJ48bLeoN/t +ibUO7os1inEqEJgMat25qveOXQ/+EURVolVqrVXM3BPQPS9sj+kLr41MIt67R4KGnIlda1ibrU Bxv1/ramxNMGJfHlvblS75HLLkCo6rf2Tmt15oHVW0GIMBuAVfilCZCC9TCLbsdj1KtRItM/Rnb ikn8uF3xkLGKSVbYcGOsA9p+5Pzvt3AH8EkVEqAeurqA== X-Gm-Gg: ASbGnctPBwMOBlZDu05OeeBnh/NF6AFqaBnji8hKgN638qyaYvWfXO9zDwnnIWP4MwN bzvYE7J7UusodDWwfxeT/4RKu+ra8mKDb4/JzrEkDXv5iXU+K6GwM8fvcMNC7Co2e81KAOu8pEl khAi66tueOm5dxm0jL9UuEISoBwQcpF15FtfL9x5+6TmBIl/YCnoTok6pt/wU7kI1qs6eAdjj8h g35NkjdB7eyjvcWKZVJnsHSwOypTg8pgW8nuylGZV8FAeXS6U1S2iKWKwvqvPl7IFTeDs0vltW/ YHJPssc7a+JGMEDPik0WM8vfwSK3HhksbxLGwq/Bjc5xeoP2uKnYSF+BL4KLD8jdGnsM0YImg6f MNkJPPHZrKBJu0jBTjjCK4rbOKtkzmf0J/MS0lxjNBGBs1h7jCh6QCMS8lD7m X-Received: by 2002:a05:600c:548a:b0:46e:6d5f:f68 with SMTP id 5b1f17b1804b1-4711787a2cdmr173963975e9.12.1761234343058; Thu, 23 Oct 2025 08:45:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENvjJfnRqlEPVbQJG/5+2SRFe/+XvUSWY4e9vS8wIYZ+gnFtpWxD3L8rMa8r5ek+Ptfbuv2w== X-Received: by 2002:a05:600c:548a:b0:46e:6d5f:f68 with SMTP id 5b1f17b1804b1-4711787a2cdmr173963305e9.12.1761234342435; Thu, 23 Oct 2025 08:45:42 -0700 (PDT) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-135-146.abo.bbox.fr. [213.44.135.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475cad4c81dsm44883515e9.0.2025.10.23.08.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Oct 2025 08:45:41 -0700 (PDT) From: Valentin Schneider To: Frederic Weisbecker , LKML Cc: Frederic Weisbecker , Michal =?utf-8?Q?Koutn?= =?utf-8?Q?=C3=BD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Michal Hocko , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Waiman Long , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 05/33] sched/isolation: Save boot defined domain flags In-Reply-To: <20251013203146.10162-6-frederic@kernel.org> References: <20251013203146.10162-1-frederic@kernel.org> <20251013203146.10162-6-frederic@kernel.org> Date: Thu, 23 Oct 2025 17:45:40 +0200 Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 13/10/25 22:31, Frederic Weisbecker wrote: > HK_TYPE_DOMAIN will soon integrate not only boot defined isolcpus= CPUs > but also cpuset isolated partitions. > > Housekeeping still needs a way to record what was initially passed > to isolcpus= in order to keep these CPUs isolated after a cpuset > isolated partition is modified or destroyed while containing some of > them. > > Create a new HK_TYPE_DOMAIN_BOOT to keep track of those. > > Signed-off-by: Frederic Weisbecker > Reviewed-by: Phil Auld > --- > include/linux/sched/isolation.h | 1 + > kernel/sched/isolation.c | 5 +++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h > index d8501f4709b5..da22b038942a 100644 > --- a/include/linux/sched/isolation.h > +++ b/include/linux/sched/isolation.h > @@ -7,6 +7,7 @@ > #include > > enum hk_type { > + HK_TYPE_DOMAIN_BOOT, > HK_TYPE_DOMAIN, > HK_TYPE_MANAGED_IRQ, > HK_TYPE_KERNEL_NOISE, > diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c > index a4cf17b1fab0..8690fb705089 100644 > --- a/kernel/sched/isolation.c > +++ b/kernel/sched/isolation.c > @@ -11,6 +11,7 @@ > #include "sched.h" > > enum hk_flags { > + HK_FLAG_DOMAIN_BOOT = BIT(HK_TYPE_DOMAIN_BOOT), > HK_FLAG_DOMAIN = BIT(HK_TYPE_DOMAIN), > HK_FLAG_MANAGED_IRQ = BIT(HK_TYPE_MANAGED_IRQ), > HK_FLAG_KERNEL_NOISE = BIT(HK_TYPE_KERNEL_NOISE), > @@ -216,7 +217,7 @@ static int __init housekeeping_isolcpus_setup(char *str) > > if (!strncmp(str, "domain,", 7)) { > str += 7; > - flags |= HK_FLAG_DOMAIN; > + flags |= HK_FLAG_DOMAIN | HK_FLAG_DOMAIN_BOOT; > continue; > } > > @@ -246,7 +247,7 @@ static int __init housekeeping_isolcpus_setup(char *str) > > /* Default behaviour for isolcpus without flags */ > if (!flags) > - flags |= HK_FLAG_DOMAIN; > + flags |= HK_FLAG_DOMAIN | HK_FLAG_DOMAIN_BOOT; I got stupidly confused by the cpumask_andnot() used later on since these are housekeeping cpumasks and not isolated ones; AFAICT HK_FLAG_DOMAIN_BOOT is meant to be a superset of HK_FLAG_DOMAIN - or, put in a way my brain comprehends, NOT(HK_FLAG_DOMAIN) (i.e. runtime isolated cpumask) is a superset of NOT(HK_FLAG_DOMAIN_BOOT) (i.e. boottime isolated cpumask), thus the final shape of cpu_is_isolated() makes sense: static inline bool cpu_is_isolated(int cpu) { return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN); } Could we document that to make it a bit more explicit? Maybe something like enum hk_type { /* Set at boot-time via the isolcpus= cmdline argument */ HK_TYPE_DOMAIN_BOOT, /* * Updated at runtime via isolated cpusets; strict subset of * HK_TYPE_DOMAIN_BOOT as it accounts for boot-time isolated CPUs. */ HK_TYPE_DOMAIN, ... }