From: Changli Gao <xiaosuo@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: batch skb dequeueing from softnet input_pkt_queue
Date: Wed, 14 Apr 2010 06:43:07 +0800 [thread overview]
Message-ID: <y2j412e6f7f1004131543m500ef7f3q2b9210ea58a80755@mail.gmail.com> (raw)
In-Reply-To: <20100413155227.GC2538@linux.vnet.ibm.com>
On Tue, Apr 13, 2010 at 11:52 PM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> On Tue, Apr 13, 2010 at 05:50:29PM +0800, Changli Gao wrote:
>> On Tue, Apr 13, 2010 at 4:08 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> >
>> > Probably not necessary.
>> >
>> >> + volatile bool flush_processing_queue;
>> >
>> > Use of 'volatile' is strongly discouraged, I would say, forbidden.
>>
>> volatile is used to avoid compiler optimization.
>
> Would it be reasonable to use ACCESS_ONCE() where this variable is used?
Oh, thanks. ACCESS_ONCE() is just what I need.
--
Regards，
Changli Gao(xiaosuo@gmail.com)
prev parent reply other threads:[~2010-04-13 22:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 15:38 [PATCH v2] net: batch skb dequeueing from softnet input_pkt_queue Changli Gao
2010-04-13 8:08 ` Eric Dumazet
2010-04-13 9:50 ` Changli Gao
2010-04-13 10:19 ` Eric Dumazet
2010-04-13 10:23 ` Eric Dumazet
2010-04-13 12:53 ` Changli Gao
2010-04-13 13:21 ` Eric Dumazet
2010-04-13 13:38 ` Changli Gao
2010-04-13 14:37 ` Eric Dumazet
2010-04-13 15:52 ` Paul E. McKenney
2010-04-13 22:43 ` Changli Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y2j412e6f7f1004131543m500ef7f3q2b9210ea58a80755@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).