* [PATCH 2/2] igbvf: dobule increment nr_frags
@ 2010-04-15 7:23 Koki Sanagi
2010-04-15 18:05 ` Jeff Kirsher
0 siblings, 1 reply; 2+ messages in thread
From: Koki Sanagi @ 2010-04-15 7:23 UTC (permalink / raw)
To: netdev, e1000-devel
Cc: davem, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
peter.p.waskiewicz.jr, john.ronciak
There is no need to increment nr_frags becasue skb_fill_page_desc increments
it.
Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
---
drivers/net/igbvf/netdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/igbvf/netdev.c b/drivers/net/igbvf/netdev.c
index ea8abf5..97cfc60 100644
--- a/drivers/net/igbvf/netdev.c
+++ b/drivers/net/igbvf/netdev.c
@@ -288,7 +288,7 @@ static bool igbvf_clean_rx_irq(struct igbvf_adapter *adapter,
PCI_DMA_FROMDEVICE);
buffer_info->page_dma = 0;
- skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
+ skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
buffer_info->page,
buffer_info->page_offset,
length);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] igbvf: dobule increment nr_frags
2010-04-15 7:23 [PATCH 2/2] igbvf: dobule increment nr_frags Koki Sanagi
@ 2010-04-15 18:05 ` Jeff Kirsher
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2010-04-15 18:05 UTC (permalink / raw)
To: Koki Sanagi
Cc: e1000-devel, netdev, bruce.w.allan, jesse.brandeburg,
john.ronciak, davem
2010/4/15 Koki Sanagi <sanagi.koki@jp.fujitsu.com>:
> There is no need to increment nr_frags becasue skb_fill_page_desc increments
> it.
>
> Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
> ---
> drivers/net/igbvf/netdev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Thanks I have added this patch to my queue of patches.
--
Cheers,
Jeff
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-15 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-15 7:23 [PATCH 2/2] igbvf: dobule increment nr_frags Koki Sanagi
2010-04-15 18:05 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).