From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB8AC43381 for ; Wed, 10 Feb 2021 11:44:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 308E864E5B for ; Wed, 10 Feb 2021 11:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbhBJLny (ORCPT ); Wed, 10 Feb 2021 06:43:54 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:3781 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbhBJLlS (ORCPT ); Wed, 10 Feb 2021 06:41:18 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 10 Feb 2021 03:40:36 -0800 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 10 Feb 2021 11:40:36 +0000 Received: from reg-r-vrt-018-180.nvidia.com (172.20.145.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 10 Feb 2021 11:40:33 +0000 References: User-agent: mu4e 1.4.10; emacs 27.1 From: Vlad Buslov To: Dan Carpenter CC: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Jakub Kicinski , Dmytro Linkin , Roi Dayan , , , Subject: Re: [PATCH net-next] net/mlx5: Fix a NULL vs IS_ERR() check In-Reply-To: Date: Wed, 10 Feb 2021 13:40:31 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612957236; bh=FBeNc2L+fAZkiQczix+2+HCC51/e8lgy3251THYIsXc=; h=References:User-agent:From:To:CC:Subject:In-Reply-To:Date: Message-ID:MIME-Version:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=Z7Wnd+A7WFHjkLZgXlnkBnb6LK+IH9GHzAcBrUgSWl0uIBk5htRDEDc7DoM9sbmdH eP2PQ/NzSNVPnpK2LzDZWNsGCQvGs6W1ZV0xX2MDoT1b/e8t5yITFSVkr7REWwcRc6 M2EZSh4iou4x9DF8EP/NYXtfacoaUB/2VZ0Fy84XCQmIL4Pe8onWgu7F6l6VVzRY4e W0pD6GSqAZE7rq1xeVQF8HObd5Jlcich8GuoBKQGvkFd/7TjqzvQuLsGgFPE8PNA+w x/K/8MRcbOKzYoTIkjqigPpkYCrXtuc+TNod0bz3iyKJxeHhMrB0BU6VYqTIucZwQY 4kgkmJnTrAmyw== Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed 10 Feb 2021 at 13:06, Dan Carpenter wrote: > The mlx5_chains_get_table() function doesn't return NULL, it returns > error pointers so we need to fix this condition. > > Fixes: 34ca65352ddf ("net/mlx5: E-Switch, Indirect table infrastructure") > Signed-off-by: Dan Carpenter Thanks, Dan! Reviewed-by: Vlad Buslov