From: Jes Sorensen <jes@wildopensource.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@oss.sgi.com
Subject: Re: [PATCH] kill acient compat cruft from acenic
Date: 29 Feb 2004 14:10:26 -0500 [thread overview]
Message-ID: <yq0u119g0rh.fsf@wildopensource.com> (raw)
In-Reply-To: <20040228182907.GA2930@lst.de>
>>>>> "Christoph" == Christoph Hellwig <hch@lst.de> writes:
Christoph> On Sat, Feb 28, 2004 at 01:27:46PM -0500, Jes Sorensen
Christoph> wrote:
>> Yeah I am happy to kill support for < 2.4.18 in the driver. But
>> don't add that offset_in_page macro please, it's butt ugly.
Christoph> I didn't add it - it's that way in 2.6, I just provided a
Christoph> variant for 2.4 (which is indetical to what you open-code
Christoph> in your 2.4 driver)
Grmbl,
Gains us nothing and is butt ugly, but well ;-( Not going to blame you
for that then, though I'd prefer a patch pulling out the macro use so
one can see what the code does instead.
Anyway, bigger fish to fry.
Jes
next prev parent reply other threads:[~2004-02-29 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-27 20:25 [PATCH] kill acient compat cruft from acenic Christoph Hellwig
2004-02-27 20:55 ` Jeff Garzik
2004-02-27 20:57 ` Christoph Hellwig
2004-02-27 20:58 ` Jeff Garzik
2004-02-28 18:27 ` Jes Sorensen
2004-02-28 18:29 ` Christoph Hellwig
2004-02-29 19:10 ` Jes Sorensen [this message]
2004-02-29 18:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0u119g0rh.fsf@wildopensource.com \
--to=jes@wildopensource.com \
--cc=hch@lst.de \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).