From: "Måns Rullgård" <mans@mansr.com>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Martin Blumenstingl <martin.blumenstingl@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Zefir Kurtisi <zefir.kurtisi@neratec.com>,
Timur Tabi <timur@codeaurora.org>, Daniel Mack <zonque@gmail.com>,
netdev <netdev@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
Mason <slash.tmp@free.fr>
Subject: Re: [PATCH v2 2/4] net: ethernet: nb8800: Set RGMII_MODE for all RGMII modes
Date: Fri, 21 Jul 2017 14:00:57 +0100 [thread overview]
Message-ID: <yw1x379qq706.fsf@mansr.com> (raw)
In-Reply-To: <237905ff-385e-fa2f-bbbf-6c550a48e15c@sigmadesigns.com> (Marc Gonzalez's message of "Fri, 21 Jul 2017 13:25:52 +0200")
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> There are 4 RGMII phy-modes to handle.
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Acked-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/net/ethernet/aurora/nb8800.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 041cfb7952f8..ded041dbafe7 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -609,7 +609,7 @@ static void nb8800_mac_config(struct net_device *dev)
> mac_mode |= HALF_DUPLEX;
>
> if (gigabit) {
> - if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII)
> + if (phy_interface_is_rgmii(dev->phydev))
> mac_mode |= RGMII_MODE;
>
> mac_mode |= GMAC_MODE;
> --
> 2.11.0
>
--
Måns Rullgård
next prev parent reply other threads:[~2017-07-21 13:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 11:22 [PATCH v2 0/4] RGMII RX and TX clock delays using Atheros 8035 Marc Gonzalez
2017-07-21 11:25 ` [PATCH v2 1/4] net: phy: at803x: Document RGMII RX and TX clock delay issues Marc Gonzalez
2017-07-21 13:20 ` Timur Tabi
2017-07-21 13:29 ` Marc Gonzalez
2017-07-21 14:06 ` Timur Tabi
2017-07-21 14:36 ` Marc Gonzalez
2017-07-21 11:25 ` [PATCH v2 2/4] net: ethernet: nb8800: Set RGMII_MODE for all RGMII modes Marc Gonzalez
2017-07-21 13:00 ` Måns Rullgård [this message]
2017-07-21 18:06 ` Florian Fainelli
2017-07-21 11:26 ` [PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup Marc Gonzalez
2017-07-21 13:04 ` Måns Rullgård
2017-07-21 13:43 ` Marc Gonzalez
2017-07-21 13:47 ` Måns Rullgård
2017-07-21 14:18 ` Marc Gonzalez
2017-07-21 14:24 ` Måns Rullgård
2017-07-21 18:15 ` Florian Fainelli
2017-07-21 11:29 ` [PATCH v2 4/4] ARM: dts: tango4: Add RGMII RX and TX clock delays Marc Gonzalez
2017-07-21 12:47 ` [PATCH v2 0/4] RGMII RX and TX clock delays using Atheros 8035 Marc Gonzalez
2017-07-21 13:16 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x379qq706.fsf@mansr.com \
--to=mans@mansr.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=martin.blumenstingl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
--cc=thibaud_cornic@sigmadesigns.com \
--cc=timur@codeaurora.org \
--cc=zefir.kurtisi@neratec.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).