From: "Måns Rullgård" <mans@mansr.com>
To: Sebastian Frias <sf84@laposte.net>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions
Date: Mon, 07 Nov 2016 11:51:27 +0000 [thread overview]
Message-ID: <yw1xk2cfik3k.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <58205103.4090208@laposte.net> (Sebastian Frias's message of "Mon, 7 Nov 2016 11:01:39 +0100")
Sebastian Frias <sf84@laposte.net> writes:
> Hi Måns,
>
> On 11/05/2016 01:58 PM, Måns Rullgård wrote:
>>> if (gigabit) {
>>> - if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII)
>>> + if (phy_interface_is_rgmii(phydev))
>>> mac_mode |= RGMII_MODE;
>>>
>>> mac_mode |= GMAC_MODE;
>>
>> As I said before, this part can/should be applied separately, although
>> personally I probably wouldn't have bothered adding a single-use variable.
>
> It was for consistency with other functions that use 'phydev', but I don't
> mind making the changes.
>
> Just to be clear, when you say "can/should be applied separately", do you
> mean that this patch should not be part of a series, and that I should split
> the series into separate patches?
I meant that this change should be made regardless of the others and can
be done separately if desired.
--
Måns Rullgård
prev parent reply other threads:[~2016-11-07 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 18:21 [PATCH v3 0/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias
2016-11-04 18:22 ` [PATCH v3 1/2] " Sebastian Frias
2016-11-04 18:23 ` [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions Sebastian Frias
2016-11-05 12:58 ` Måns Rullgård
2016-11-07 10:01 ` Sebastian Frias
2016-11-07 11:51 ` Måns Rullgård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xk2cfik3k.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).