From: "Måns Rullgård" <mans@mansr.com>
To: Mason <slash.tmp@free.fr>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: vitesse: add support for VSC8601
Date: Fri, 13 Nov 2015 10:06:19 +0000 [thread overview]
Message-ID: <yw1xk2pmkyck.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <5645A48E.9090402@free.fr> (Mason's message of "Fri, 13 Nov 2015 09:51:26 +0100")
Mason <slash.tmp@free.fr> writes:
> On 12/11/2015 19:41, Mans Rullgard wrote:
>
>> + .phy_id = PHY_ID_VSC8601,
>> + .name = "Vitesse VSC8601",
>> + .phy_id_mask = 0x000ffff0,
>> + .features = PHY_GBIT_FEATURES,
>> + .flags = PHY_HAS_INTERRUPT,
>> + .config_init = &genphy_config_init,
>> + .config_aneg = &genphy_config_aneg,
>> + .read_status = &genphy_read_status,
>> + .ack_interrupt = &vsc824x_ack_interrupt,
>> + .config_intr = &vsc82xx_config_intr,
>
> I expected Documentation/CodingStyle to forbid taking the address
> of functions.
I can't find anything to that effect. That said, it's not something I
would normally do, but all the other phy_driver entries in that file
look like that.
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-11-13 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 18:41 [PATCH] net: phy: vitesse: add support for VSC8601 Mans Rullgard
2015-11-12 19:15 ` Florian Fainelli
2015-11-13 8:51 ` Mason
2015-11-13 10:06 ` Måns Rullgård [this message]
2015-11-16 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xk2pmkyck.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).