From: "Måns Rullgård" <mans@mansr.com>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Mason <slash.tmp@free.fr>, netdev <netdev@vger.kernel.org>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
David Miller <davem@davemloft.net>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()
Date: Wed, 15 Nov 2017 15:36:22 +0000 [thread overview]
Message-ID: <yw1xmv3nzh8p.fsf@mansr.com> (raw)
In-Reply-To: <e3dfc32f-7052-603d-659a-0a7d9d7453b0@sigmadesigns.com> (Marc Gonzalez's message of "Wed, 15 Nov 2017 16:19:56 +0100")
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> On 15/11/2017 16:03, Andrew Lunn wrote:
>
>> On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote:
>>
>>> On 15/11/2017 15:17, Andrew Lunn wrote:
>>>
>>> In our local branch, I have completely disabled flow control support,
>>> so I don't have to worry about this problem.
>>
>> That is an interesting statement. You now know there is an issue here,
>> your solution is to fix your private branch and leave mainline as is.
>
> All my patches are NACKed, what would you have me do?
>
> Moreover, mainline still has the nb8800_dma_stop() work-around,
> which Mans has never seen hang.
Here's the thing, if that trick doesn't work, then the dma queue filling
up from real traffic will also hang the controller, which is a much
bigger problem. Your test today suggests that this might be the case.
--
Måns Rullgård
next prev parent reply other threads:[~2017-11-15 15:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 10:53 [PATCH v3 0/4] Various nb8800 tweaks Marc Gonzalez
2017-11-14 10:54 ` [PATCH v3 1/4] net: nb8800: Drop generic support Marc Gonzalez
2017-11-14 12:37 ` Måns Rullgård
2017-11-14 12:47 ` Marc Gonzalez
2017-11-14 13:03 ` Måns Rullgård
2017-11-14 10:55 ` [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config() Marc Gonzalez
2017-11-14 12:38 ` Måns Rullgård
2017-11-14 12:56 ` Marc Gonzalez
2017-11-14 13:22 ` Måns Rullgård
2017-11-15 10:53 ` Marc Gonzalez
2017-11-15 14:17 ` Andrew Lunn
2017-11-15 14:33 ` Marc Gonzalez
2017-11-15 15:03 ` Andrew Lunn
2017-11-15 15:19 ` Marc Gonzalez
2017-11-15 15:36 ` Måns Rullgård [this message]
2017-11-15 21:12 ` Andrew Lunn
2017-11-14 10:56 ` [PATCH v3 3/4] net: nb8800: Move HW init to ndo_open() Marc Gonzalez
2017-11-14 12:40 ` Måns Rullgård
2017-11-14 13:26 ` Marc Gonzalez
2017-11-14 13:54 ` Måns Rullgård
2017-11-14 16:41 ` Marc Gonzalez
2017-11-14 16:55 ` Måns Rullgård
2017-11-14 17:07 ` Marc Gonzalez
2017-11-15 14:58 ` Marc Gonzalez
2017-11-15 15:11 ` Måns Rullgård
2017-11-15 16:15 ` Marc Gonzalez
2017-11-16 12:21 ` Marc Gonzalez
2017-11-16 16:23 ` Andrew Lunn
2017-11-16 16:52 ` Marc Gonzalez
2017-11-14 12:04 ` [PATCH v3 4/4] net: nb8800: Add support for suspend/resume Marc Gonzalez
2017-11-14 13:02 ` Måns Rullgård
2017-11-14 14:22 ` Marc Gonzalez
2017-11-14 16:31 ` Andrew Lunn
2017-11-14 17:08 ` Marc Gonzalez
2017-11-14 17:33 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xmv3nzh8p.fsf@mansr.com \
--to=mans@mansr.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).