From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F809C433F5 for ; Thu, 10 Feb 2022 13:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241054AbiBJNs2 convert rfc822-to-8bit (ORCPT ); Thu, 10 Feb 2022 08:48:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233034AbiBJNs1 (ORCPT ); Thu, 10 Feb 2022 08:48:27 -0500 X-Greylist: delayed 76448 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 10 Feb 2022 05:48:27 PST Received: from unicorn.mansr.com (unicorn.mansr.com [IPv6:2001:8b0:ca0d:8d8e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B747191; Thu, 10 Feb 2022 05:48:27 -0800 (PST) Received: from raven.mansr.com (raven.mansr.com [IPv6:2001:8b0:ca0d:8d8e::3]) by unicorn.mansr.com (Postfix) with ESMTPS id 6107F15360; Thu, 10 Feb 2022 13:48:25 +0000 (GMT) Received: by raven.mansr.com (Postfix, from userid 51770) id 4A572219C0A; Thu, 10 Feb 2022 13:48:25 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Jakub Kicinski Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Vladimir Oltean , Juergen Borleis , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: lan9303: fix reset on probe References: <20220209145454.19749-1-mans@mansr.com> <20220209183623.54369689@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Date: Thu, 10 Feb 2022 13:48:25 +0000 In-Reply-To: <20220209183623.54369689@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (Jakub Kicinski's message of "Wed, 9 Feb 2022 18:36:23 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jakub Kicinski writes: > On Wed, 9 Feb 2022 14:54:54 +0000 Mans Rullgard wrote: >> The reset input to the LAN9303 chip is active low, and devicetree >> gpio handles reflect this. Therefore, the gpio should be requested >> with an initial state of high in order for the reset signal to be >> asserted. Other uses of the gpio already use the correct polarity. >> >> Signed-off-by: Mans Rullgard > > Pending Andrew's review, this is the correct fixes tag, right? > > Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303") Yes, the error has been there since the driver was first added. -- Måns Rullgård